Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ViewEmail.php #45

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update ViewEmail.php #45

merged 1 commit into from
Apr 16, 2024

Conversation

marcogermani87
Copy link
Collaborator

Autoload custom Resource from config

Autoload custom Resource from config
Copy link

what-the-diff bot commented Apr 15, 2024

PR Summary 🎉

  • Improved Resource Retrieval in ViewEmail.php File 🔧
    The getResource() method has been updated. Now, it smoothly gets values from a configuration option named filament-email.resource.class. And guess what? If that option isn't set, it doesn't panic 😅 Instead, it confidently falls back on a plan B, using EmailResource::class. This change enhances flexibility and increases resilience. 👍

@RickDBCN RickDBCN self-assigned this Apr 16, 2024
@RickDBCN
Copy link
Owner

Thanks!

@RickDBCN RickDBCN merged commit f22f40f into RickDBCN:main Apr 16, 2024
5 checks passed
@marcogermani87
Copy link
Collaborator Author

Thanks!

Hi Rick, i've made some interesting changes on my fork (https://github.com/marcogermani87/filament-email/):

  • Loading plugin throgh ::make() method
  • Table and form view rework
  • Advanced search for created_at field (From/To date)
  • Added translations support (EN/IT for now)
  • Confirm modal for re-send e-mail action
  • Scoped filter for Email model for enhance table free search

Take a look and if you agree i can make a PR for this changes.

Regards.

@RickDBCN
Copy link
Owner

Thanks!

Hi Rick, i've made some interesting changes on my fork (https://github.com/marcogermani87/filament-email/):

* Loading plugin throgh ::make() method

* Table and form view rework

* Advanced search for created_at field (From/To date)

* Added translations support (EN/IT for now)

* Confirm modal for re-send e-mail action

* Scoped filter for Email model for enhance table free search

Take a look and if you agree i can make a PR for this changes.

Regards.

Hi Marco! Great work! :)
Could you make a PR for these changes? Would be highly appreciated.

Can you update the screenshots to English?

Many thanks!

@marcogermani87
Copy link
Collaborator Author

Thanks!

Hi Rick, i've made some interesting changes on my fork (https://github.com/marcogermani87/filament-email/):

* Loading plugin throgh ::make() method

* Table and form view rework

* Advanced search for created_at field (From/To date)

* Added translations support (EN/IT for now)

* Confirm modal for re-send e-mail action

* Scoped filter for Email model for enhance table free search

Take a look and if you agree i can make a PR for this changes.
Regards.

Hi Marco! Great work! :) Could you make a PR for these changes? Would be highly appreciated.

Can you update the screenshots to English?

Many thanks!

Yes, sure! I'll try to do this tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants