Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cap updates to generate functions of FE/FF #2788

Closed
wants to merge 0 commits into from
Closed

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Jan 16, 2025

#2787

  • Move cap updates to generate functions of FE/FF
  • Extended service to include optional capService & added enableNPMWorkspaces to appOptions of FE/FF
  • Move CapService and CapRuntime types from @sap-ux/odata-service-inquirer to @sap-ux/cap-config-writer for better relevance.

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 2a7d3ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sap-ux/odata-service-inquirer Major
@sap-ux/cap-config-writer Minor
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/create Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review January 17, 2025 12:35
@kjose90 kjose90 requested review from a team as code owners January 17, 2025 12:35
devinea
devinea previously approved these changes Jan 17, 2025
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look clean and straightforward.
Changeset ✅

Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one doc update please thx.

Copy link

cla-assistant bot commented Jan 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ korotkovao
✅ kjose90
❌ github-actions


github-actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -118,8 +118,21 @@ export function getSystemServiceQuestion(
}
return serviceChoices;
},
additionalMessages: (selectedService: ServiceAnswer) =>
getSelectedServiceMessage(serviceChoices, selectedService, connectValidator, requiredOdataVersion),
additionalMessages: (selectedService: ServiceAnswer) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem to be from a bad merge?

@@ -310,6 +312,13 @@ export async function getSelectedServiceMessage(
if (selectedService) {
let serviceType = selectedService.serviceType;
if (selectedService.serviceODataVersion === ODataVersion.v2) {
// Warn if odata service is version is '2' and no annotations are present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from another commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants