-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cap updates to generate functions of FE/FF #2788
Conversation
🦋 Changeset detectedLatest commit: 2a7d3ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look clean and straightforward.
Changeset ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one doc update please thx.
github-actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -118,8 +118,21 @@ export function getSystemServiceQuestion( | |||
} | |||
return serviceChoices; | |||
}, | |||
additionalMessages: (selectedService: ServiceAnswer) => | |||
getSelectedServiceMessage(serviceChoices, selectedService, connectValidator, requiredOdataVersion), | |||
additionalMessages: (selectedService: ServiceAnswer) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem to be from a bad merge?
@@ -310,6 +312,13 @@ export async function getSelectedServiceMessage( | |||
if (selectedService) { | |||
let serviceType = selectedService.serviceType; | |||
if (selectedService.serviceODataVersion === ODataVersion.v2) { | |||
// Warn if odata service is version is '2' and no annotations are present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from another commit?
Quality Gate passedIssues Measures |
2a7d3ae
to
d855e0e
Compare
#2787
generate
functions of FE/FFcapService
& addedenableNPMWorkspaces
toappOptions
of FE/FFCapService
andCapRuntime
types from@sap-ux/odata-service-inquirer
to@sap-ux/cap-config-writer
for better relevance.