Test for type properties instead of testing for the OS #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No real changes, but use more consistent name: the type is called "int64_t" and not "int64".
Check if int64_t is the same type as long at CMake level, while still providing fallback definitions for non-CMake builds in the header too. This allows to stop explicitly testing the platform, at least in the non-fallback case.
Using these constants is not the right way to decide whether we do something or not, so remove them to avoid the temptation.
Test for this in CMake and avoid specializing exchange_traits<char> in this case. Closes SOCI#1154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be more robust and easier to extend.