Add stepper motor driver firmware to sra-board-component #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAtacker
requested changes
Jan 14, 2023
Comment on lines
+108
to
+109
| #define STEP 14 | ||
| #define DIR 27 |
There was a problem hiding this comment.
These macros define the pins to which the STEP pin and DIRECTION pins are connected to ESP32.
we cannot name it STEP_DIR
There was a problem hiding this comment.
Also is STEP okay? it needs to mean something atleast
There was a problem hiding this comment.
I can make it STEP_SIGNAL_PIN and DIR_SIGNAL_PIN
There was a problem hiding this comment.
DIR_SIGNAL_PIN should be related to the stepper.
There was a problem hiding this comment.
CC @gautam-dev-maker suggest a better naming scheme
|
lastly squash your commits into one single commit after removing dda7369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @gautam-dev-maker ,
I have added the firmware and example for stepper motor control, please do check it out :)