-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service abstraction #1855
Merged
Merged
Service abstraction #1855
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
"""This module includes an abstraction over source services in the Open Build | ||
Service. | ||
|
||
""" | ||
|
||
import xml.etree.ElementTree as ET | ||
from dataclasses import dataclass | ||
from dataclasses import field | ||
from typing import Literal | ||
|
||
|
||
@dataclass(kw_only=True, frozen=True) | ||
class Service: | ||
"""Representation of an arbitrary source service in the Open Build Service.""" | ||
|
||
#: name of this service | ||
name: str | ||
|
||
#: unsorted list of parameters of this source service as a list of tuples | ||
#: where the first value is the parameter's name and the second is the | ||
#: parameter's value | ||
param: list[tuple[str, str]] = field(default_factory=list) | ||
|
||
#: service mode (i.e. when the service runs) | ||
mode: Literal["buildtime"] = "buildtime" | ||
|
||
def as_xml_element(self) -> ET.Element: | ||
"""Coverts this source service into a | ||
:py:class:`~xml.etree.ElementTree.Element`. | ||
|
||
""" | ||
root = ET.Element("service", attrib={"name": self.name, "mode": self.mode}) | ||
|
||
for param in self.param: | ||
(p := ET.Element("param", attrib={"name": param[0]})).text = param[1] | ||
root.append(p) | ||
|
||
return root | ||
|
||
def __str__(self) -> str: | ||
return ET.tostring(self.as_xml_element()).decode("utf-8") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to the beginning, e.g. before mode? I prefer to have non-optional dataclass members first