make components optional un/controllable and init with values #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensee
requested review from
Mathias-a,
robines and
Snorre98
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes in This PR
Refactored Checkbox & Input components to enforce best practices for controlled vs. uncontrolled behavior, preventing React warnings.
Introduced PrimitiveCheckboxProps and PrimitiveInputProps for better type safety and reusability.
Extracted getDefaultValues helper in RecruitmentPositionForm to centralize default values and improve maintainability.
Ensured form inputs always receive defined values by updating useForm initialization and form.reset().
Improved readability & structure by simplifying prop handling, restructuring long expressions, and using optional chaining.