Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onert-micro] Enable ReducedProd op #14510

Merged
merged 6 commits into from
Feb 4, 2025
Merged

[onert-micro] Enable ReducedProd op #14510

merged 6 commits into from
Feb 4, 2025

Conversation

chunseoklee
Copy link
Contributor

  • enable reduced product operation in onert-micro
  • Note that prevoious name for ReducedProd is ReducedCommon(?)

ONE-DCO-1.0-Signed-off-by: Chunseok Lee chunseok.lee@samsung.com

@chunseoklee
[onert-micro] Enable ReducedProd op
71a1979 
- enable reduced product operation in onert-micro
- Note that prevoious name for ReducedProd is ReducedCommon(?)

ONE-DCO-1.0-Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
@chunseoklee chunseoklee mentioned this pull request Jan 2, 2025
Open
7 tasks
@chunseoklee chunseoklee requested a review from SlavikMIPT January 3, 2025 06:27
@chunseoklee chunseoklee marked this pull request as ready for review January 3, 2025 06:27
@chunseoklee chunseoklee mentioned this pull request Jan 3, 2025
Open
@chunseoklee chunseoklee requested a review from Torrero January 16, 2025 04:39
Torrero
Torrero previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SlavikMIPT
SlavikMIPT requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, please fix include guard

onert-micro/onert-micro/include/pal/mcu/PALReduceCommon.h Outdated Show resolved Hide resolved
@chunseoklee @SlavikMIPT
Update onert-micro/onert-micro/include/pal/mcu/PALReduceCommon.h
e7eb05f 
Co-authored-by: SlavikMIPT <slavikmipt@gmail.com>
Torrero
Torrero previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Torrero
Torrero previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunseoklee chunseoklee mentioned this pull request Feb 3, 2025
Open
SlavikMIPT
SlavikMIPT approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunseoklee chunseoklee merged commit d91cd58 into Samsung:master Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlavikMIPT SlavikMIPT SlavikMIPT approved these changes

@Torrero Torrero Torrero left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunseoklee @Torrero @SlavikMIPT