Add tests for VMware secureboot provisioning #17214

Gauravtalreja1 · 2024-12-20T15:35:59Z

Problem Statement

Missing test coverage for new feature of VMware secureboot provisioning

Solution

Update existing tests to include VMware UEFI secureboot provisioning

Related Issues

Gauravtalreja1 · 2024-12-20T15:37:25Z

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-12-20T21:03:09Z

PRT Result

Build Number: 9685
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : == 11 failed, 19 passed, 18 deselected, 1168 warnings in 18965.08s (5:16:05) ===

Gauravtalreja1 · 2024-12-21T21:46:02Z

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-12-22T03:09:21Z

PRT Result

Build Number: 9688
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : === 9 failed, 18 passed, 18 deselected, 1163 warnings in 19035.54s (5:17:15) ===

Gauravtalreja1 · 2024-12-22T22:37:02Z

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-12-23T03:59:23Z

PRT Result

Build Number: 9690
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : === 4 failed, 23 passed, 18 deselected, 1159 warnings in 19042.78s (5:17:22) ===

Satellite-QE · 2024-12-23T04:11:38Z

PRT Result

Build Number: 9692
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : === 4 failed, 23 passed, 18 deselected, 1182 warnings in 19479.40s (5:24:39) ===

Gauravtalreja1 · 2024-12-23T23:34:34Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-12-24T00:51:38Z

PRT Result

Build Number: 9704
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 3 failed, 12 deselected, 89 warnings in 4165.74s (1:09:25) ==========

Gauravtalreja1 · 2024-12-26T12:05:08Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-12-26T13:24:56Z

PRT Result

Build Number: 9709
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========= 6 failed, 12 deselected, 232 warnings in 4368.58s (1:12:48) ==========

Gauravtalreja1 · 2024-12-30T15:20:35Z

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2025-01-01T01:21:42Z

PRT Result

Build Number: 9719
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : = 27 failed, 9 passed, 18 deselected, 1892 warnings, 4 errors in 122089.33s (1 day, 9:54:49) =

Satellite-QE · 2025-01-02T03:57:16Z

PRT Result

Build Number: 9720
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : = 9 failed, 9 passed, 18 deselected, 1599 warnings, 21 errors in 20151.05s (5:35:51) =

Gauravtalreja1 · 2025-01-09T08:46:42Z

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2025-01-09T13:42:33Z

PRT Result

Build Number: 9796
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ======== 39 failed, 18 deselected, 2099 warnings in 17408.41s (4:50:08) ========

Gauravtalreja1 · 2025-01-10T21:51:51Z

trigger: test-robottelo
pytest: tests/foreman/api/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

Satellite-QE · 2025-01-11T04:54:47Z

PRT Result

Build Number: 9828
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ======== 24 failed, 2 deselected, 1086 warnings in 11177.24s (3:06:17) =========

Gauravtalreja1 · 2025-01-23T22:31:38Z

trigger: test-robottelo
pytest: tests/foreman/api/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH__BACKEND: hussh

Satellite-QE · 2025-01-24T06:18:50Z

PRT Result

Build Number: 9977
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : === 16 failed, 8 passed, 2 deselected, 2550 warnings in 27697.16s (7:41:37) ====

Gauravtalreja1 · 2025-01-28T09:35:58Z

Waiting on RedHatQE/wrapanapi#501

nofaralfasi · 2025-01-28T09:39:45Z

tests/foreman/api/test_computeresource_vmware.py

-@pytest.mark.rhel_ver_match('[8]')
+@pytest.mark.rhel_ver_list('[9, 10]')


why did we remove rhel 8 here?

We're now running EL9 and EL10 provisioning tests with API, since its faster compared to CLI/UI

nofaralfasi · 2025-01-28T09:42:31Z

tests/foreman/api/test_computeresource_vmware.py

@@ -98,6 +109,7 @@ def test_positive_provision_end_to_end(
                    'controller_key': 1001,
                },
            },
+            'virtual_tpm': 'false' if pxe_loader.vm_firmware == 'bios' else 'true',


This should work, but in the hammer PR we mentioned that the value should be 0 or 1 theforeman/hammer-cli-foreman#630

yes, both works, but I think both makes sense, so do we really need to change it?

nofaralfasi · 2025-01-28T09:44:19Z

tests/foreman/cli/test_computeresource_vmware.py

-@pytest.mark.rhel_ver_match(r'^(?!.*fips).*$')
+@pytest.mark.rhel_ver_match('[7]')


@Gauravtalreja1 Could you please explain this change?

We're just running EL7 provisioning tests with CLI

tests/foreman/ui/test_computeresource_vmware.py

Gauravtalreja1 · 2025-01-28T21:38:30Z

trigger: test-robottelo
pytest: tests/foreman/api/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH__BACKEND: hussh

Satellite-QE · 2025-01-29T05:18:47Z

PRT Result

Build Number: 10003
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : === 13 failed, 11 passed, 2 deselected, 2601 warnings in 27069.92s (7:31:09) ===

Gauravtalreja1 · 2025-01-29T13:54:47Z

trigger: test-robottelo
pytest: tests/foreman/{cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH__BACKEND: hussh

Satellite-QE · 2025-01-29T14:35:58Z

PRT Result

Build Number: 10010
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{cli,ui}/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 3 failed, 16 deselected, 321 warnings, 12 errors in 2013.92s (0:33:33) ====

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Gauravtalreja1 · 2025-01-29T15:50:50Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH__BACKEND: hussh

Satellite-QE · 2025-01-29T16:24:17Z

PRT Result

Build Number: 10011
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 3 failed, 12 deselected, 58 warnings in 1626.39s (0:27:06) ==========

Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Dec 20, 2024

Gauravtalreja1 self-assigned this Dec 20, 2024

Gauravtalreja1 requested review from a team as code owners December 20, 2024 15:35

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 20, 2024

Gauravtalreja1 force-pushed the vmware-sb branch from da5653f to 169d55e Compare December 21, 2024 21:28

Gauravtalreja1 force-pushed the vmware-sb branch from 169d55e to c3b2c63 Compare December 22, 2024 22:36

Gauravtalreja1 force-pushed the vmware-sb branch from c3b2c63 to 50bf798 Compare December 23, 2024 23:34

Gauravtalreja1 force-pushed the vmware-sb branch from 50bf798 to 022dd95 Compare December 26, 2024 12:04

Gauravtalreja1 force-pushed the vmware-sb branch from 022dd95 to 110eb8d Compare December 30, 2024 15:19

Gauravtalreja1 force-pushed the vmware-sb branch from 110eb8d to be6a7fc Compare January 9, 2025 08:46

Gauravtalreja1 force-pushed the vmware-sb branch from be6a7fc to a86f487 Compare January 23, 2025 22:30

Gauravtalreja1 force-pushed the vmware-sb branch from a86f487 to 8b96ccb Compare January 27, 2025 09:45

nofaralfasi reviewed Jan 28, 2025

View reviewed changes

Gauravtalreja1 force-pushed the vmware-sb branch from 26fec4d to 1d5c6ea Compare January 28, 2025 21:37

Gauravtalreja1 added 5 commits January 29, 2025 21:17

Add tests for VMware secureboot provisioning

0eeb6b3

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Add EL10 parameter along with EL9 for VMware provisioning

d30d908

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Shuffled the RHEL versions for api, cli, and ui modules

468fb96

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Add virtual_tpm compute attribute while creating host

d42ab4a

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Add check to validate if vTPM device is added to VM on VMware

84028c4

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Gauravtalreja1 force-pushed the vmware-sb branch from 1d5c6ea to 84028c4 Compare January 29, 2025 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for VMware secureboot provisioning #17214

Add tests for VMware secureboot provisioning #17214

Gauravtalreja1 commented Dec 20, 2024

Gauravtalreja1 commented Dec 20, 2024

Satellite-QE commented Dec 20, 2024

Gauravtalreja1 commented Dec 21, 2024

Satellite-QE commented Dec 22, 2024

Gauravtalreja1 commented Dec 22, 2024

Satellite-QE commented Dec 23, 2024

Satellite-QE commented Dec 23, 2024

Gauravtalreja1 commented Dec 23, 2024

Satellite-QE commented Dec 24, 2024

Gauravtalreja1 commented Dec 26, 2024

Satellite-QE commented Dec 26, 2024

Gauravtalreja1 commented Dec 30, 2024

Satellite-QE commented Jan 1, 2025

Satellite-QE commented Jan 2, 2025

Gauravtalreja1 commented Jan 9, 2025

Satellite-QE commented Jan 9, 2025

Gauravtalreja1 commented Jan 10, 2025

Satellite-QE commented Jan 11, 2025

Gauravtalreja1 commented Jan 23, 2025

Satellite-QE commented Jan 24, 2025

Gauravtalreja1 commented Jan 28, 2025

nofaralfasi Jan 28, 2025

Gauravtalreja1 Jan 29, 2025

nofaralfasi Jan 28, 2025

Gauravtalreja1 Jan 29, 2025

nofaralfasi Jan 28, 2025

Gauravtalreja1 Jan 29, 2025

Gauravtalreja1 commented Jan 28, 2025

Satellite-QE commented Jan 29, 2025

Gauravtalreja1 commented Jan 29, 2025

Satellite-QE commented Jan 29, 2025

Gauravtalreja1 commented Jan 29, 2025

Satellite-QE commented Jan 29, 2025

		@pytest.mark.rhel_ver_match('[8]')
		@pytest.mark.rhel_ver_list('[9, 10]')

		@pytest.mark.rhel_ver_match(r'^(?!.fips).$')
		@pytest.mark.rhel_ver_match('[7]')

Add tests for VMware secureboot provisioning #17214

Are you sure you want to change the base?

Add tests for VMware secureboot provisioning #17214

Conversation

Gauravtalreja1 commented Dec 20, 2024

Problem Statement

Solution

Related Issues

Gauravtalreja1 commented Dec 20, 2024

Satellite-QE commented Dec 20, 2024

Gauravtalreja1 commented Dec 21, 2024

Satellite-QE commented Dec 22, 2024

Gauravtalreja1 commented Dec 22, 2024

Satellite-QE commented Dec 23, 2024

Satellite-QE commented Dec 23, 2024

Gauravtalreja1 commented Dec 23, 2024

Satellite-QE commented Dec 24, 2024

Gauravtalreja1 commented Dec 26, 2024

Satellite-QE commented Dec 26, 2024

Gauravtalreja1 commented Dec 30, 2024

Satellite-QE commented Jan 1, 2025

Satellite-QE commented Jan 2, 2025

Gauravtalreja1 commented Jan 9, 2025

Satellite-QE commented Jan 9, 2025

Gauravtalreja1 commented Jan 10, 2025

Satellite-QE commented Jan 11, 2025

Gauravtalreja1 commented Jan 23, 2025

Satellite-QE commented Jan 24, 2025

Gauravtalreja1 commented Jan 28, 2025

nofaralfasi Jan 28, 2025

Choose a reason for hiding this comment

Gauravtalreja1 Jan 29, 2025

Choose a reason for hiding this comment

nofaralfasi Jan 28, 2025

Choose a reason for hiding this comment

Gauravtalreja1 Jan 29, 2025

Choose a reason for hiding this comment

nofaralfasi Jan 28, 2025

Choose a reason for hiding this comment

Gauravtalreja1 Jan 29, 2025

Choose a reason for hiding this comment

Gauravtalreja1 commented Jan 28, 2025

Satellite-QE commented Jan 29, 2025

Gauravtalreja1 commented Jan 29, 2025

Satellite-QE commented Jan 29, 2025

Gauravtalreja1 commented Jan 29, 2025

Satellite-QE commented Jan 29, 2025