Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Vue Router integration #2600

Merged
merged 27 commits into from
Jan 30, 2025

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Jan 24, 2025

Relates to #447

Implement Vue Router integration by supporting and using OnyxRouterLink component and useLink composable.

Checklist

  • The added / edited code has been documented with JSDoc
  • All changes are documented in the documentation app (folder apps/docs)
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: d8eeab4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert force-pushed the larsrickert/447-vue-router-integration branch from 8344e96 to 834b35d Compare January 24, 2025 11:11
@larsrickert larsrickert changed the title [DRAFT] feat: implement Vue Router integration feat: implement Vue Router integration Jan 24, 2025
@larsrickert larsrickert marked this pull request as ready for review January 24, 2025 11:36
@larsrickert larsrickert requested a review from a team as a code owner January 24, 2025 11:36
@JoCa96 JoCa96 self-assigned this Jan 30, 2025
@larsrickert larsrickert force-pushed the larsrickert/447-vue-router-integration branch from 106fc7b to b4fdc0c Compare January 30, 2025 11:00
@larsrickert larsrickert requested a review from JoCa96 January 30, 2025 11:21
@JoCa96 JoCa96 enabled auto-merge January 30, 2025 15:02
@JoCa96 JoCa96 force-pushed the larsrickert/447-vue-router-integration branch from 40d4a8f to d8eeab4 Compare January 30, 2025 15:02
@JoCa96 JoCa96 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit de1cc16 Jan 30, 2025
20 checks passed
@JoCa96 JoCa96 deleted the larsrickert/447-vue-router-integration branch January 30, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants