-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Vue Router integration #2600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8eeab4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
larsrickert
force-pushed
the
larsrickert/447-vue-router-integration
branch
from
January 24, 2025 11:11
8344e96
to
834b35d
Compare
larsrickert
changed the title
[DRAFT] feat: implement Vue Router integration
feat: implement Vue Router integration
Jan 24, 2025
JoCa96
requested changes
Jan 30, 2025
packages/sit-onyx/src/components/OnyxRouterLink/OnyxRouterLink.ct.tsx
Outdated
Show resolved
Hide resolved
larsrickert
force-pushed
the
larsrickert/447-vue-router-integration
branch
from
January 30, 2025 11:00
106fc7b
to
b4fdc0c
Compare
packages/sit-onyx/src/components/OnyxRouterLink/OnyxRouterLink.ct.tsx
Dismissed
Show dismissed
Hide dismissed
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <67898185+larsrickert@users.noreply.github.com>
JoCa96
force-pushed
the
larsrickert/447-vue-router-integration
branch
from
January 30, 2025 15:02
40d4a8f
to
d8eeab4
Compare
JoCa96
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #447
Implement Vue Router integration by supporting and using OnyxRouterLink component and useLink composable.
Checklist
apps/docs
)npx changeset add
if your changes should be released as npm package (because they affect the library usage)