Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(OnyxColorSchemeDialog): fix Storybook example when open property is set manually #2623

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs(OnyxColorSchemeDialog): fix Storybook example when open property is set manually #2623

wants to merge 2 commits into from
+79 −46

Conversation

larsrickert
Copy link
Collaborator

Relates to #2384 (comment)

Currently, when setting the open property manually, the close button did not close the dialog again.

@larsrickert larsrickert requested a review from a team as a code owner January 27, 2025 08:30
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 96a0fed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@larsrickert larsrickert changed the title docs(OnyxColorSchemeDialog): fix Storybook example when open property… docs(OnyxColorSchemeDialog): fix Storybook example when open property is set manually Jan 27, 2025
@larsrickert larsrickert requested a review from JoCa96 January 28, 2025 14:43
@larsrickert larsrickert enabled auto-merge January 28, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoCa96 JoCa96 Awaiting requested review from JoCa96

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsrickert @JoCa96