Skip to content

Commit

Permalink
fix #40 by explicitly depending on websocket@#head (#42)
Browse files Browse the repository at this point in the history 
For some reason just using
```
requires "websocket#head"
```
does not seem to work on my machine.
  • Loading branch information
@Vindaar
Vindaar authored Jan 28, 2019
1 parent 06e8823 commit 69592e1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion plotly.nimble
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ description = "plotting library for nim"
license = "MIT"


requires "nim >= 0.18.0", "chroma", "websocket", "jsbind", "webview"
requires "nim >= 0.18.0", "chroma", "jsbind", "webview"
# get head to fix https://github.com/brentp/nim-plotly/issues/40
# Remove once websocket has new version tag
requires "https://github.com/niv/websocket.nim#head"

srcDir = "src"

skipDirs = @["tests"]
Expand Down

1 comment on commit 69592e1

@timotheecour
Copy link
Contributor

@timotheecour timotheecour commented on 69592e1 Jan 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason just using requires "websocket#head" does not seem to work on my machine.

@Vindaar this is obsoleted by #44 but I can't reproduce the issue u're having w requires "websocket#head"

# this works
requires "nim >= 0.18.0", "chroma", "websocket", "jsbind", "webview#head"

# this works too
requires "nim >= 0.18.0", "chroma", "websocket", "jsbind"
requires "websocket#head"

Please sign in to comment.