Changed status and object cache file serialization from JSON to Messa…

…gePack; implemented StringBuilderPool to minimize allocations; various other bug fixes and perf/allocation improvements.
ScottArbeit · Dec 21, 2024 · 5c49ed0 · 5c49ed0
1 parent 4043124
commit 5c49ed0
Show file tree

Hide file tree

Showing 38 changed files with 1,352 additions and 694 deletions.
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
@@ -0,0 +1,18 @@
+Be more formal in the information presented, but not in addressing the user. Give longer, more comprehensive answers when answering questions, but not when performing tasks like writing code or generating text. Assume the user has a post-graduate level of education and is an experienced programmer.
+
+When asked for help organizing a task, assume the user has inattentive-type ADHD and needs help breaking the task down into multiple, smaller steps. Use knowledge from CBT for ADHD as guidance and assist the user in getting started.
+
+For questions about programming, assume the programming language is F#, unless told otherwise.
+Code samples should be provided in F#, unless told otherwise.
+All scripts should be generated in PowerShell unless told otherwise.
+All F# code uses the `task { }` computation expression to handle asynchronous operations.
+All F# code should be written in a functional style, using immutability and pure functions where possible.
+All F# code should the new syntax when referring to arrays, lists, and sequences: use `myArray[0]` instead of `myArray.[0]`.
+
+All code output should be complete, exhaustive, and full, and should be ready for copy/paste. Include comments in the code where appropriate, and informational logging of important variable values for any functions longer than ten lines.
+
+Provide an English description of the generated code.
+
+If task breakdown is requested for programming, generate discrete steps that could be placed on a Kanban board as separate tasks.
+
+If you don't know the answer to a question, simply say "I don't know."
diff --git a/src/CosmosSerializer/CosmosJsonSerializer.csproj b/src/CosmosSerializer/CosmosJsonSerializer.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
 		<TargetFramework>net9.0</TargetFramework>
@@ -9,7 +9,8 @@
 	</PropertyGroup>
 	<ItemGroup>
 		<PackageReference Include="Azure.Core" Version="1.44.1" />
-		<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.46.0-preview.2" />
+		<PackageReference Include="Ben.Demystifier" Version="0.4.1" />
+		<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.46.0" />
         <PackageReference Include="System.Net.Http" Version="4.3.4" />
         <PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
         <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />

diff --git a/src/Grace.Actors/Branch.Actor.fs b/src/Grace.Actors/Branch.Actor.fs
@@ -407,7 +407,7 @@ module Branch =
                         return
                             Error(
                                 GraceError.Create
-                                    $"{actorName} does not process reminder type {discriminatedUnionCaseName reminder.ReminderType}."
+                                    $"{actorName} does not process reminder type {getDiscriminatedUnionCaseName reminder.ReminderType}."
                                     this.correlationId
                             )
                 }

diff --git a/src/Grace.Actors/Context.Actor.fs b/src/Grace.Actors/Context.Actor.fs
@@ -56,10 +56,5 @@ module Context =
     /// Setter for memory cache
     let setMemoryCache (cache: IMemoryCache) = memoryCache <- cache
 
-    let mutable internal stringBuilderPool: ObjectPool<StringBuilder> = null
-
-    /// Setter for the string builder pool
-    let setStringBuilderPool (pool: ObjectPool<StringBuilder>) = stringBuilderPool <- pool
-
     let mutable internal timings = ConcurrentDictionary<CorrelationId, List<Timing>>()
     let setTimings (timing: ConcurrentDictionary<CorrelationId, List<Timing>>) = timings <- timing
diff --git a/src/Grace.Actors/Diff.Actor.fs b/src/Grace.Actors/Diff.Actor.fs
@@ -262,7 +262,7 @@ module Diff =
                         return
                             Error(
                                 (GraceError.Create
-                                    $"{actorName} does not process reminder type {discriminatedUnionCaseName reminder.ReminderType}."
+                                    $"{actorName} does not process reminder type {getDiscriminatedUnionCaseName reminder.ReminderType}."
                                     this.correlationId)
                                     .enhance ("IsRetryable", "false")
                             )

diff --git a/src/Grace.Actors/DirectoryVersion.Actor.fs b/src/Grace.Actors/DirectoryVersion.Actor.fs
@@ -252,7 +252,7 @@ module DirectoryVersion =
                         return
                             Error(
                                 (GraceError.Create
-                                    $"{actorName} does not process reminder type {discriminatedUnionCaseName reminder.ReminderType}."
+                                    $"{actorName} does not process reminder type {getDiscriminatedUnionCaseName reminder.ReminderType}."
                                     this.correlationId)
                                     .enhance ("IsRetryable", "false")
                             )

diff --git a/src/Grace.Actors/Grace.Actors.fsproj b/src/Grace.Actors/Grace.Actors.fsproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
 		<TargetFramework>net9.0</TargetFramework>
@@ -50,10 +50,11 @@
 		<PackageReference Include="Azure.Storage.Blobs" Version="12.23.0" />
 		<PackageReference Include="Azure.Storage.Blobs.Batch" Version="12.20.0" />
 		<PackageReference Include="Azure.Storage.Common" Version="12.22.0" />
+		<PackageReference Include="Ben.Demystifier" Version="0.4.1" />
 		<PackageReference Include="Dapr.Actors" Version="1.14.0" />
 		<PackageReference Include="Dapr.Client" Version="1.14.0" />
-		<PackageReference Include="FSharpPlus" Version="1.6.1" />
-		<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.46.0-preview.2" />
+		<PackageReference Include="FSharpPlus" Version="1.7.0" />
+		<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.46.0" />
 		<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="9.0.0" />
 		<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
 		<PackageReference Include="Nito.AsyncEx" Version="5.1.2" />

diff --git a/src/Grace.Actors/Organization.Actor.fs b/src/Grace.Actors/Organization.Actor.fs
@@ -317,7 +317,7 @@ module Organization =
                         return
                             Error(
                                 GraceError.Create
-                                    $"{actorName} does not process reminder type {discriminatedUnionCaseName reminder.ReminderType}."
+                                    $"{actorName} does not process reminder type {getDiscriminatedUnionCaseName reminder.ReminderType}."
                                     this.correlationId
                             )
                 }

diff --git a/src/Grace.Actors/Owner.Actor.fs b/src/Grace.Actors/Owner.Actor.fs
@@ -311,7 +311,7 @@ module Owner =
                         return
                             Error(
                                 GraceError.Create
-                                    $"{actorName} does not process reminder type {discriminatedUnionCaseName reminder.ReminderType}."
+                                    $"{actorName} does not process reminder type {getDiscriminatedUnionCaseName reminder.ReminderType}."
                                     this.correlationId
                             )
                 }

diff --git a/src/Grace.Actors/Reference.Actor.fs b/src/Grace.Actors/Reference.Actor.fs
@@ -228,7 +228,7 @@ module Reference =
                         return
                             Error(
                                 (GraceError.Create
-                                    $"{actorName} does not process reminder type {discriminatedUnionCaseName reminder.ReminderType}."
+                                    $"{actorName} does not process reminder type {getDiscriminatedUnionCaseName reminder.ReminderType}."
                                     this.correlationId)
                                     .enhance ("IsRetryable", "false")
                             )
@@ -305,7 +305,7 @@ module Reference =
                             .enhance(nameof (BranchId), $"{referenceDto.BranchId}")
                             .enhance(nameof (ReferenceId), $"{referenceDto.ReferenceId}")
                             .enhance(nameof (DirectoryVersionId), $"{referenceDto.DirectoryId}")
-                            .enhance(nameof (ReferenceType), $"{discriminatedUnionCaseName referenceDto.ReferenceType}")
+                            .enhance(nameof (ReferenceType), $"{getDiscriminatedUnionCaseName referenceDto.ReferenceType}")
                             .enhance (nameof (ReferenceEventType), $"{getDiscriminatedUnionFullName referenceEvent.Event}")
 
                     return Ok graceReturnValue
@@ -319,7 +319,7 @@ module Reference =
                             .enhance(nameof (BranchId), $"{referenceDto.BranchId}")
                             .enhance(nameof (ReferenceId), $"{referenceDto.ReferenceId}")
                             .enhance(nameof (DirectoryVersionId), $"{referenceDto.DirectoryId}")
-                            .enhance(nameof (ReferenceType), $"{discriminatedUnionCaseName referenceDto.ReferenceType}")
+                            .enhance(nameof (ReferenceType), $"{getDiscriminatedUnionCaseName referenceDto.ReferenceType}")
                             .enhance (nameof (ReferenceEventType), $"{getDiscriminatedUnionFullName referenceEvent.Event}")
 
                     return Error graceError

diff --git a/src/Grace.Actors/Repository.Actor.fs b/src/Grace.Actors/Repository.Actor.fs
@@ -431,7 +431,7 @@ module Repository =
                         return
                             Error(
                                 GraceError.Create
-                                    $"{actorName} does not process reminder type {discriminatedUnionCaseName reminder.ReminderType}."
+                                    $"{actorName} does not process reminder type {getDiscriminatedUnionCaseName reminder.ReminderType}."
                                     this.correlationId
                             )
                 }