Remove configuring deprecated formatting rules #455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove configuration of deprecated formatting rules.
Per https://eslint.org/blog/2023/10/deprecating-formatting-rules/ and https://typescript-eslint.io/blog/deprecating-formatting-rules several formatting related rules have been deprecated from
eslint
core andtypescript-eslint
and moved into@stylistic/eslint-plugin
. These rules are removed in typescript-eslint v8 (released) and probably eslint v10 (unreleased).To prepare for future updates we are removing our configuration of these rules. We recommend that you use Prettier (https://prettier.io/) for formatting considerations - either by running it in parallel with ESLint or as part of ESLint through using
eslint-plugin-prettier
via theprettier
config provided by@shopify/eslint-plugin
. If you do not wish to use Prettier, then we suggest you configure rules from@stylistic/eslint-plugin
(https://eslint.style/packages/default).Note that if you already use the
prettier
config then this removal will have no effect as all these rules were already turned off.Configuration for the following rules in the
es5
,esnext
andtypescript
configs have been removed:From
typescript-eslint
:From ESLint core:
We retain configuration for the following rules for the moment - even though they are depreated - as prettier does not have opinions about whitespace in these cases: