clean up metricRegistry in close() (#7)

SimpleFinance · Sep 13, 2017 · 087cad5 · 087cad5
1 parent 9ed0ecd
commit 087cad5
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/main/java/com/simple/metrics/kafka/DropwizardReporter.java b/src/main/java/com/simple/metrics/kafka/DropwizardReporter.java
@@ -12,13 +12,16 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
+import java.util.HashSet;
 
 public class DropwizardReporter implements MetricsReporter {
     private static final Logger LOGGER = LoggerFactory.getLogger(DropwizardReporter.class);
     protected static final String METRIC_PREFIX = MetricsReporter.class.getPackage().getName();
 
     protected MetricRegistry registry;
     protected DropwizardReporterConfig config;
+    private Set<String> metricNames = new HashSet<>();
 
     @Override
     public void configure(Map<String, ?> configs) {
@@ -51,6 +54,7 @@ public Double getValue() {
         LOGGER.debug("Registering {}", name);
         try {
             registry.register(name, gauge);
+            metricNames.add(name);
         } catch (IllegalArgumentException e) {
             LOGGER.warn("metricChange called for `{}' which was already registered, ignoring.", name);
         }
@@ -61,10 +65,14 @@ public void metricRemoval(KafkaMetric kafkaMetric) {
         String name = dropwizardMetricName(kafkaMetric);
         LOGGER.debug("Removing {}", name);
         registry.remove(name);
+        metricNames.remove(name);
     }
 
     @Override
-    public void close() {}
+    public void close() {
+        for (String name: metricNames)
+            registry.remove(name);
+    }
 
     private static String dropwizardMetricName(KafkaMetric kafkaMetric) {
         MetricName name = kafkaMetric.metricName();