Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check-types script #11

Merged
merged 1 commit into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 0 additions & 85 deletions .eslintrc.json

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ jobs:
- run: npm install --include=dev
- name: Check linting
run: npm run lint
- name: Check types
run: npm run check-types
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,9 @@ git checkout -b my-new-feature
- When you finished your changes, you must check your code's formatting and linting and fix all the errors.

```bash
npm run lint:fix
npm run format
npm run lint:fix # check for linting errors
npm run check-types # check for type errors
npm run format # comply with formatting rules
```

- After that, add your changes to `CHANGELOG.md` and update the README if needed.
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"lint": "eslint .",
"lint:fix": "eslint --fix .",
"format": "prettier ./src/**/*.ts --config prettier.config.mjs --write",
"check-types": "tsc --noEmit",
"clean": "shx rm -rf ./dist",
"build:cjs": "tsc -m commonjs --target es2017 --outDir ./dist/lib-cjs/",
"build:esm": "tsc -m es6 --target es2017 --outDir ./dist/lib-esm/",
Expand Down