fix(okta): remove duplicate credentials #1150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
requested changes
Feb 15, 2024
Co-authored-by: Lucas Michot <lucas@semalead.com>
lucasmichot
approved these changes
Feb 15, 2024
|
I've reverted the original PR. |
Thanks for the head up @driesvints - I'll have a look at that |
|
Closing as laravel/socialite#694 reverts the introduction of the bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
laravel/socialite#684 added the client_id and client_secret to the Authorization header in addition to the request body, however Okta throws an error if multiple credentials are provided, so they must be removed from the body before sending the request.