Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery Starbot ⭐ refactored SoulMelody/hls-get #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hls_get/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ async def download(links, path, names, coros, headers, timeout, clean_up, verify
headers_parser = HeadersParser()
header_lines = [b'', *(line.encode('latin-1') for line in headers), b'']
parsed_headers, raw_headers = headers_parser.parse_headers(header_lines)
kwargs = dict()
kwargs = {}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function download refactored with the following changes:

if not verify:
kwargs['connector'] = TCPConnector(verify_ssl=False)
for link, name in zip_longest(links, names):
Expand Down
92 changes: 44 additions & 48 deletions hls_get/downloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(self, link, path, name, coros, timeout, clean_up=True, **kwargs):
self.sem = asyncio.Semaphore(coros)
self.path = path
self.timeout = timeout or None
self.key_cache = dict()
self.key_cache = {}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function HLSDownloader.__init__ refactored with the following changes:

self.clean_up = clean_up

async def __aenter__(self):
Expand All @@ -45,11 +45,10 @@ async def __aexit__(self, *args):
@cached_property
def retry_wrapper(cls):
ctx = click.get_current_context()
wrapper = tenacity.retry(
return tenacity.retry(
wait=tenacity.wait_fixed(ctx.params['delay']),
stop=tenacity.stop_after_attempt(ctx.params['retry_times'])
stop=tenacity.stop_after_attempt(ctx.params['retry_times']),
)
return wrapper
Comment on lines -48 to -52
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function HLSDownloader.retry_wrapper refactored with the following changes:


@cached_property
def cache_dir(self):
Expand All @@ -66,12 +65,9 @@ def on_success(self):
@retry_with_options
async def fetch_with_retry(self, link, text=False):
with async_timeout.timeout(self.timeout):
async with self.sem, self.session.get(link) as resp:
async with (self.sem, self.session.get(link) as resp):
resp.raise_for_status()
if text:
return await resp.text()
else:
return await resp.read()
return await resp.text() if text else await resp.read()
Comment on lines -69 to +70
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function HLSDownloader.fetch_with_retry refactored with the following changes:


async def download_segment(self, seq_num, segment, bar):
filename = f'{self.cache_dir}/{seq_num}.ts'
Expand All @@ -90,45 +86,45 @@ async def download_segment(self, seq_num, segment, bar):

async def download(self, link):
m3u8_obj = m3u8.loads(await self.fetch_with_retry(link, text=True), uri=link)
if not m3u8_obj.media_sequence:
if m3u8_obj.is_variant:
for i, playlist in enumerate(m3u8_obj.playlists):
click.echo(
f'{i}: bandwidth={playlist.stream_info.bandwidth} '
f'resolution={playlist.stream_info.resolution} '
f'codecs={playlist.stream_info.codecs} '
)
index = click.prompt(
'Which playlist to download?',
type=click.Choice(list(range(len(m3u8_obj.playlists)))),
value_proc=int,
default=0
if m3u8_obj.media_sequence:
click.echo('Live streaming media is not suppported!')

elif m3u8_obj.is_variant:
for i, playlist in enumerate(m3u8_obj.playlists):
click.echo(
f'{i}: bandwidth={playlist.stream_info.bandwidth} '
f'resolution={playlist.stream_info.resolution} '
f'codecs={playlist.stream_info.codecs} '
)
return await self.download(m3u8_obj.playlists[index].absolute_uri)
else:
tmp_list = m3u8.M3U8()
tmp_list.version = '3'
tmp_list.media_sequence = '0'
tmp_list.target_duration = m3u8_obj.target_duration
tmp_list.is_endlist = True
tasks = []
os.makedirs(self.cache_dir, exist_ok=True)
bar = ShadyBar(self.name, max=len(m3u8_obj.segments), suffix='%(percent).1f%% - %(eta_td)s')
for i, segment in enumerate(m3u8_obj.segments):
tmp_list.add_segment(
m3u8.Segment(
f'{os.path.realpath(self.cache_dir)}/{i}.ts',
duration=segment.duration,
base_uri='file://'
)
index = click.prompt(
'Which playlist to download?',
type=click.Choice(list(range(len(m3u8_obj.playlists)))),
value_proc=int,
default=0
)
return await self.download(m3u8_obj.playlists[index].absolute_uri)
else:
tmp_list = m3u8.M3U8()
tmp_list.version = '3'
tmp_list.media_sequence = '0'
tmp_list.target_duration = m3u8_obj.target_duration
tmp_list.is_endlist = True
tasks = []
os.makedirs(self.cache_dir, exist_ok=True)
bar = ShadyBar(self.name, max=len(m3u8_obj.segments), suffix='%(percent).1f%% - %(eta_td)s')
for i, segment in enumerate(m3u8_obj.segments):
tmp_list.add_segment(
m3u8.Segment(
f'{os.path.realpath(self.cache_dir)}/{i}.ts',
duration=segment.duration,
base_uri='file://'
)
tasks.append(
asyncio.ensure_future(
self.download_segment(i, segment, bar)
)
)
tasks.append(
asyncio.ensure_future(
self.download_segment(i, segment, bar)
)
tmp_list.dump(f'{self.cache_dir}/filelist.m3u8')
await asyncio.gather(*tasks)
bar.finish()
else:
click.echo('Live streaming media is not suppported!')
)
tmp_list.dump(f'{self.cache_dir}/filelist.m3u8')
await asyncio.gather(*tasks)
bar.finish()
Comment on lines -93 to +130
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function HLSDownloader.download refactored with the following changes: