Skip to content

Commit

Permalink
KAFKA-18316 Fix to Kraft or remove tests associate with Zk Broker con…
Browse files Browse the repository at this point in the history
…fig in ConnectionQuotasTest (apache#18279)

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
  • Loading branch information
m1a2st authored Dec 29, 2024
1 parent 96527be commit f2ae20a
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,12 @@ class ConnectionQuotasTest {
}

def brokerPropsWithDefaultConnectionLimits: Properties = {
val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port = 0)
val props = TestUtils.createBrokerConfig(0, null, port = 0)
props.put(SocketServerConfigs.LISTENERS_CONFIG, "EXTERNAL://localhost:0,REPLICATION://localhost:1,ADMIN://localhost:2")
// ConnectionQuotas does not limit inter-broker listener even when broker-wide connection limit is reached
props.put(ReplicationConfigs.INTER_BROKER_LISTENER_NAME_CONFIG, "REPLICATION")
props.put(SocketServerConfigs.LISTENER_SECURITY_PROTOCOL_MAP_CONFIG, "EXTERNAL:PLAINTEXT,REPLICATION:PLAINTEXT,ADMIN:PLAINTEXT")
props.put(SocketServerConfigs.ADVERTISED_LISTENERS_CONFIG, "REPLICATION://localhost:1")
props.put(SocketServerConfigs.LISTENER_SECURITY_PROTOCOL_MAP_CONFIG, "PLAINTEXT:PLAINTEXT,CONTROLLER:PLAINTEXT,EXTERNAL:PLAINTEXT,REPLICATION:PLAINTEXT,ADMIN:PLAINTEXT")
props.put(QuotaConfig.NUM_QUOTA_SAMPLES_CONFIG, numQuotaSamples.toString)
props.put(QuotaConfig.QUOTA_WINDOW_SIZE_SECONDS_CONFIG, quotaWindowSizeSeconds.toString)
props
Expand Down

0 comments on commit f2ae20a

Please sign in to comment.