Refactor code

Tes3awy · Jun 15, 2021 · ba6cadc · ba6cadc
1 parent 018b210
commit ba6cadc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/read_subnets.py b/read_subnets.py
@@ -17,9 +17,10 @@ def read_subnets(file_path: str = "subnets.csv") -> list[list]:
     # Read subnets CSV file
     with open(file=file_path, mode="r") as csvfile:
         next(csvfile)  # Skip header line
-        csv_data = csv.reader(csvfile, delimiter=",")
-
+        csv_data = csv.reader(
+            csvfile, delimiter="\n", dialect="excel", doublequote=True
+        )
         for subnet in csv_data:
-            subnets.append(subnet)
+            subnets.append(subnet[0])
 
     return subnets
diff --git a/subnetting.py b/subnetting.py
@@ -24,8 +24,8 @@ def subnetting(input_subnets: list[list]) -> list[dict]:
     try:
         results = []
         # Loop over input_subnets
-        for netsubnet in input_subnets:
-            cidr_notation = ipaddress.IPv4Network(netsubnet[0])
+        for net_subnet in input_subnets:
+            cidr_notation = ipaddress.IPv4Network(net_subnet)
 
             # Find range of IP addresses
             hosts = list(cidr_notation.hosts())