test exclude_authors #536

rachmadaniHaryono · 2022-02-04T05:55:41Z

Related Issue/Addition to code

Please delete options that are not relevant.

Fixes #
Issue/Addition to code, goes here.

test exclude_authors

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Proposed Changes

test Scripts.operations.exclude_author
type hint for Scripts.operations.exclude_author based on that test (for function parameter and result)
move comment to function docstring
set default value for addWhitelist var
handle error when S.R is not recognizeable
document raised error when calling sys.exit

Additional Info

what is default value for result, addWhitelist, chosenSampleIndexes variable?
i recommend to use isort to sort import
change on main program is not formatted for now,
maybe move while loop to a new function so it is easier to test and separate user input and logic section
on YTSpammerPurge.py there is aliasing to Style, Fore and Back object attribute but this make import submodule harder

  # Initiates colorama and creates shorthand variables for resetting colors
  init(autoreset=True)
  S.R = S.RESET_ALL
  F.R = F.RESET
  B.R = B.RESET

to run the test, install pytest and run it with pytest -s. if you use it with poetry run poetry run pytest -s.
see build: pyproject #459 to get pyproject.toml file
what is the type for current, excludedCommentsDict, authorsToExcludeSet, commentIDExcludeSet? maybe current type hint from this pr is wrong?
Scripts/operations.pyi is generated from mypy's stubgen with little change
- this is already good enough than inital handcrafted type hint guess
from contributing.md
- it is simpler pr
- Avoid adding new non-standard libraries if at all possible, but i use pytest rather than unittest for easier test and avoid boilerplate

i tried brute testing program on #476 but it failed

i think it is easier to test recent function from recent repo commit and keep it as small as possible

pyright result moved to comment below

Checklist:

My code follows the style guidelines of this project and have read CONTRIBUTING.md
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings

Screenshots

Original	Updated
** original screenshot	updated screenshot

ethnh · 2022-02-04T06:26:49Z

on YTSpammerPurge.py there is aliasing to Style, Fore and Back object attribute but this make import submodule harder

I tried to fix this in #510 by moving the alias to the shared_import file, if #510 is not merged, the alias should definitely at least be moved.

rachmadaniHaryono · 2022-02-04T06:28:53Z

if #510 accepted i will remove that part from pr

ethnh · 2022-02-04T06:35:08Z

but i use pytest rather than unittest for easier test and avoid boilerplate

As long as it doesn't need to be added to requirements.txt, I doubt @ThioJoe would mind
Running tests should generally be done before releasing anyway, no need to run tests on every run 👍

ethnh

Small and simple commit, LGTM! ✅
Hope more tests can be implemented soon

…error

rachmadaniHaryono · 2022-02-04T07:55:58Z

i forget to document SytemExit when the function calling sys.exit

YT-Spammer-Purge/Scripts/operations.py

Line 880 in 224bb22

sys.exit()

there is also error on type hint for miscData

it should be some object with resources attribute, which is a dict

YT-Spammer-Purge/Scripts/operations.py

Line 899 in 224bb22

    
           with open(miscData.resources['Whitelist']['PathWithName'], "a", encoding="utf-8") as f:

i also forget to write type hint for return value tuple

it should be the same as type hint as stated on function parameter

ThioJoe · 2022-02-05T00:45:29Z

I have no clue what this is

rachmadaniHaryono · 2022-02-05T00:46:21Z

unit test for the function (?)

ThioJoe · 2022-02-05T00:56:50Z

This is way over my head

rachmadaniHaryono · 2022-02-05T00:58:08Z

how do you test the program?

how do you make sure the function work as intended?

ThioJoe · 2022-02-05T17:07:33Z

how do you test the program?

how do you make sure the function work as intended?

I usually just try to make functions have a simple purpose so there aren't too many situations to test. Then I just see if it behaves as expected and try to come up with edge cases myself.

rachmadaniHaryono · 2022-02-05T23:06:26Z

I usually just try to make functions have a simple purpose so there aren't too many situations to test.

currently some function have comment that describe its function (and some dont)

but some (if not all) don't have description about parameter input , return value and raised error

take exclude_authors for example

can you describe parameter and its type?
does it raises exception?
from description Removes comments by user-selected authors from list of comments to delete
but it doesn't state that it will write to a
file

YT-Spammer-Purge/Scripts/operations.py

Line 899 in 3b9fb62

with open(miscData.resources['Whitelist']['PathWithName'], "a", encoding="utf-8") as f:

despite the goal of functions have a simple purpose, it clearly not what happen

so there aren't too many situations to test

with so many branching on function i doubt that

Then I just see if it behaves as expected and try to come up with edge cases myself.

manually?

so basically run it from main function?

have you try run the function by itself? for example

from Scripts import some_module

some_module.some_function(*args, **kwargs)

ThioJoe · 2022-02-08T20:51:17Z

I've been looking up how unit testing works so I am starting to see the point of this. Gonna take me a bit to delve into it though

…e_authors

rachmadaniHaryono · 2022-02-14T02:46:14Z

Scripts/operations.pyi is generated from mypy's stubgen

i also add from typing import Union

test is also matched with current exclude_authors return variable

initial pyright

No configuration file found.
pyproject.toml file found at /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge.
Loading pyproject.toml file at /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/pyproject.toml
Assuming Python platform Linux
Searching for source files
Found 1 source file
/mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:49:55 - error: Cannot access member "id" for type "None"
    Member "id" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:67:28 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:71:15 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:133:68 - error: "videoID" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:295:25 - error: Cannot access member "id" for type "None"
    Member "id" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:350:23 - error: Cannot access member "id" for type "None"
    Member "id" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:674:44 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:730:36 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:738:36 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:788:85 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:811:77 - error: "group" is not a known member of "None" (reportOptionalMemberAccess)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:814:77 - error: "group" is not a known member of "None" (reportOptionalMemberAccess)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:822:14 - error: "result" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:825:49 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:838:53 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:850:10 - error: Operator "in" not supported for types "str" and "Unbound | list[str]"
    Operator "in" not supported for types "str" and "Unbound" (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:850:32 - error: "chosenSampleIndexes" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:853:10 - error: Operator "not in" not supported for types "str" and "Unbound | list[str]"
    Operator "not in" not supported for types "str" and "Unbound" (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:853:36 - error: "chosenSampleIndexes" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:879:44 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:880:49 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:890:64 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:890:102 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:890:141 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:895:53 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:895:98 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:903:24 - error: Cannot access member "resources" for type "Dict[str, Any]"
    Member "resources" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:943:49 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:943:93 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:972:8 - error: Index 3 is out of range for type tuple[None, None, Literal['MainMenu']] (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:981:9 - error: Expression with type "tuple[None, None, Literal['MainMenu']] | tuple[Unknown | Literal['End'], int | None, int | Literal['MainMenu'], Literal['']]" cannot be assigned to target tuple
    Type "tuple[None, None, Literal['MainMenu']]" is incompatible with target tuple
      Element size mismatch; expected 4 but received 3 (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:979:9 - error: Expression with type "tuple[None, None, Literal['MainMenu']] | tuple[Unknown | Literal['End'], int | None, int | Literal['MainMenu'], Literal['']]" cannot be assigned to target tuple
    Type "tuple[None, None, Literal['MainMenu']]" is incompatible with target tuple
      Element size mismatch; expected 4 but received 3 (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:982:14 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1005:68 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1005:115 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1005:172 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1007:68 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1007:115 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1007:172 - error: Cannot access member "R" for type "AnsiStyle"
    Member "R" is unknown (reportGeneralTypeIssues)
39 errors, 0 warnings, 0 informations 
Completed in 1.963sec

pyright after 3ee9a3c

No configuration file found.
pyproject.toml file found at /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge.
Loading pyproject.toml file at /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/pyproject.toml
Assuming Python platform Linux
Searching for source files
Found 1 source file
/mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:4:36 - warning: Wildcard import from a library not allowed (reportWildcardImportFromLibrary)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:55:5 - error: "traceback" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:60:5 - error: "traceback" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:66:28 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:70:15 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:141:73 - error: "videoID" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:174:9 - error: "traceback" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:179:9 - error: "traceback" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:284:105 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:286:53 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:299:14 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:305:21 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:319:19 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:327:17 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:408:8 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:485:3 - error: "dictToUse" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:495:5 - error: "dictToUse" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:496:5 - error: "dictToUse" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:497:5 - error: "dictToUse" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:647:12 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:660:12 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:678:12 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:680:14 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:685:10 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:723:18 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:738:18 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:749:21 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:754:27 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:773:16 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:775:56 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:787:12 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:791:26 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:834:12 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:842:16 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:851:16 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:908:7 - error: "sys" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:937:14 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:937:42 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:993:36 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1001:36 - error: "results" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1051:20 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1051:83 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1070:18 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1071:13 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1071:21 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1082:24 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1090:21 - error: "replace" is not a known member of "None" (reportOptionalMemberAccess)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1079:24 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1090:14 - error: "result" is possibly unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1092:8 - error: "re" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1093:18 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1093:47 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1102:36 - error: Cannot access member "split" for type "None"
    Member "split" is unknown (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1106:22 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1106:51 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1118:10 - error: Operator "in" not supported for types "str" and "Unbound"
    Operator "in" not supported for types "str" and "Unbound" (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1118:32 - error: "chosenSampleIndexes" is unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1121:10 - error: Operator "not in" not supported for types "str" and "Unbound"
    Operator "not in" not supported for types "str" and "Unbound" (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1121:36 - error: "chosenSampleIndexes" is unbound (reportUnboundVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1165:16 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1165:42 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1166:27 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1166:47 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1169:7 - error: "sys" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1176:14 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1176:62 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1176:77 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1176:100 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1176:114 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1176:139 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1181:26 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1181:51 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1181:70 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1181:96 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1219:18 - error: "B" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1219:28 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1219:47 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1219:53 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1219:91 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1248:8 - error: Index 3 is out of range for type tuple[None, None, Literal['MainMenu']] (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1257:9 - error: Expression with type "tuple[None, None, Literal['MainMenu']] | tuple[Any | Literal['End'], int | None, int | Literal['MainMenu'], Literal['']]" cannot be assigned to target tuple
    Type "tuple[None, None, Literal['MainMenu']]" is incompatible with target tuple
      Element size mismatch; expected 4 but received 3 (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1255:9 - error: Expression with type "tuple[None, None, Literal['MainMenu']] | tuple[Any | Literal['End'], int | None, int | Literal['MainMenu'], Literal['']]" cannot be assigned to target tuple
    Type "tuple[None, None, Literal['MainMenu']]" is incompatible with target tuple
      Element size mismatch; expected 4 but received 3 (reportGeneralTypeIssues)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1258:14 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1281:44 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1281:66 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1281:91 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1281:113 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1281:143 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1281:170 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1283:44 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1283:66 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1283:91 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1283:113 - error: "S" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1283:143 - error: "F" is not defined (reportUndefinedVariable)
  /mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/YT-Spammer-Purge/Scripts/operations.py:1283:170 - error: "S" is not defined (reportUndefinedVariable)
94 errors, 1 warning, 0 informations 
Completed in 1.658sec

#536 (comment)

@EthanHindmarsh pr #510 is already merged but it is merged to beta branch

but this pr is based on main branch, so imo this should be merged after beta branch is merged to main branch

after that i will remove the relevant section and test it again

e:

to generate pyi files stubgen Scripts -o Scripts

there is error when i add YTSpammerPurge to above command

Critical error during semantic analysis: YTSpammerPurge.py: error: INTERNAL ERROR: maximum semantic analysis iteration count reached

ethnh · 2022-03-20T21:11:02Z

I've been looking up how unit testing works so I am starting to see the point of this. Gonna take me a bit to delve into it though

Do you have any questions?
Tests are currently listed as part of the PR process so it would be great to have some sort of testing added👍

rachmadaniHaryono added 2 commits February 4, 2022 12:52

test(test_operations): exclude_authors

089d2b3

fix(exclude_authors): for test

a914b3f

rachmadaniHaryono mentioned this pull request Feb 4, 2022

test YTSpammerPurge #476

Closed

17 tasks

ethnh approved these changes Feb 4, 2022

View reviewed changes

docs(exclude_authors): type hint function result and document raised …

a99ec00

…error

rachmadaniHaryono mentioned this pull request Feb 12, 2022

[Bug]: X-2 error on exclude comment #633

Closed

2 tasks

rachmadaniHaryono added 4 commits February 14, 2022 10:07

Merge remote-tracking branch 'upstream/main' into feature/test-exclud…

406498f

…e_authors

refactor(exclude_authors): reset parameter to upstream/main

d8e96dd

feat(operations): pyi from stubgen

f74f48b

test(test_exclude_authors): match result

3ee9a3c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test exclude_authors #536

test exclude_authors #536

rachmadaniHaryono commented Feb 4, 2022 •

edited

Loading

ethnh commented Feb 4, 2022

rachmadaniHaryono commented Feb 4, 2022

ethnh commented Feb 4, 2022

ethnh left a comment

rachmadaniHaryono commented Feb 4, 2022

ThioJoe commented Feb 5, 2022

rachmadaniHaryono commented Feb 5, 2022

ThioJoe commented Feb 5, 2022

rachmadaniHaryono commented Feb 5, 2022

ThioJoe commented Feb 5, 2022 •

edited

Loading

rachmadaniHaryono commented Feb 5, 2022

ThioJoe commented Feb 8, 2022

rachmadaniHaryono commented Feb 14, 2022 •

edited

Loading

ethnh commented Mar 20, 2022

test exclude_authors #536

Are you sure you want to change the base?

test exclude_authors #536

Conversation

rachmadaniHaryono commented Feb 4, 2022 • edited Loading

Related Issue/Addition to code

Type of change

Proposed Changes

Additional Info

Checklist:

Screenshots

ethnh commented Feb 4, 2022

rachmadaniHaryono commented Feb 4, 2022

ethnh commented Feb 4, 2022

ethnh left a comment

Choose a reason for hiding this comment

rachmadaniHaryono commented Feb 4, 2022

ThioJoe commented Feb 5, 2022

rachmadaniHaryono commented Feb 5, 2022

ThioJoe commented Feb 5, 2022

rachmadaniHaryono commented Feb 5, 2022

ThioJoe commented Feb 5, 2022 • edited Loading

rachmadaniHaryono commented Feb 5, 2022

ThioJoe commented Feb 8, 2022

rachmadaniHaryono commented Feb 14, 2022 • edited Loading

ethnh commented Mar 20, 2022

rachmadaniHaryono commented Feb 4, 2022 •

edited

Loading

ThioJoe commented Feb 5, 2022 •

edited

Loading

rachmadaniHaryono commented Feb 14, 2022 •

edited

Loading