Skip to content

Commit

Permalink
Correct the incorrectly scaled down buffer size (#631)
Browse files Browse the repository at this point in the history
* Correct the incorrectly scaled down buffer size

* Update NEWS and roll micro version [ci skip]

* Augment test added in #630 as suggsted post-merge
  • Loading branch information
eddelbuettel authored Dec 6, 2023
1 parent 4ce2621 commit 6c8840c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: tiledb
Type: Package
Version: 0.22.0.2
Version: 0.22.0.3
Title: Modern Database Engine for Multi-Modal Data via Sparse and Dense Multidimensional Arrays
Authors@R: c(person("TileDB, Inc.", role = c("aut", "cph")),
person("Dirk", "Eddelbuettel", email = "dirk@tiledb.com", role = "cre"))
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

* A TileDB Array can now be opened in 'keep open' mode for subsequent use without re-opening (#630)

## Bug Fixes

* The read buffer is now correctly sized when implementing VFS serialization (#631)

## Build and Test Systems

* Builds from TileDB Core non-release tarballs are now supported via new configure option (#627)
Expand Down
2 changes: 2 additions & 0 deletions inst/tinytest/test_tiledbarray.R
Original file line number Diff line number Diff line change
Expand Up @@ -1580,3 +1580,5 @@ expect_false(tiledb_array_is_open(arr))
arr <- tiledb_array(uri, keep_open=TRUE)
res <- arr[]
expect_true(tiledb_array_is_open(arr))
arr <- tiledb_array_close(arr)
expect_false(tiledb_array_is_open(arr))
2 changes: 1 addition & 1 deletion src/libtiledb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4467,7 +4467,7 @@ Rcpp::IntegerVector libtiledb_vfs_read(XPtr<tiledb::Context> ctxxp, XPtr<vfs_fh_
std::shared_ptr<tiledb_ctx_t> ctx = ctxxp.get()->ptr();
std::int64_t offs = fromInteger64(offset);
std::int64_t nb = fromInteger64(nbytes);
Rcpp::IntegerVector buf(nb/4);
Rcpp::IntegerVector buf(nb);
tiledb_vfs_read(ctx.get(), fh->fh, offs, &(buf[0]), nb);
return buf;
}
Expand Down

0 comments on commit 6c8840c

Please sign in to comment.