Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory alloc: Accomodate zero buffer size estimate v2 #777

Merged
merged 2 commits into from
Oct 25, 2024
Merged

memory alloc: Accomodate zero buffer size estimate v2 #777

merged 2 commits into from
Oct 25, 2024

Conversation

johnkerl
Copy link
Collaborator

@johnkerl johnkerl commented Oct 25, 2024 •
edited
Loading

Fixes #776 per suggestion by @cgiachalis

@johnkerl johnkerl requested a review from mojaveazure October 25, 2024 13:23
@cgiachalis
Copy link
Contributor

From #482 a ref: sc-23256 in your end..

mojaveazure
mojaveazure approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me; added one style and minor performance fix. Otherwise, please bump the develop version, update the changelog, and 🚢

R/TileDBArray.R Outdated Show resolved Hide resolved
@johnkerl @mojaveazure
code-review feedback
5f82149 
Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
@johnkerl johnkerl merged commit 849fef8 into main Oct 25, 2024
8 checks passed
@johnkerl johnkerl deleted the kerl/776 branch October 25, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojaveazure mojaveazure mojaveazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory alloc: Accomodate zero buffer size estimate v2
3 participants
@johnkerl @cgiachalis @mojaveazure