add GTM script tag #399
Merged
add GTM script tag #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add function to sanitize page pathnames in dataLayer payload events
- add function to sanitize page pathnames in dataLayer payload events
| @@ -59,3 +59,25 @@ | |||
| } | |||
| </script> | |||
| {{/ga4TagId}} | |||
|
|
|||
| {{#gtmTagId}} | |||
| <!-- Data Layer --> | |||
There was a problem hiding this comment.
what do you mean by Data layer? was this comment from you?
There was a problem hiding this comment.
it's from the snippet code sent from the business. I think it's just a comment to explain what the code is for.
| }); | ||
| return str; | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks like github actions is complaining about some linting and styling
There was a problem hiding this comment.
aaah thanks ...god I hate linting 😂
| @@ -39,22 +49,28 @@ const setupPageMap = routes => { | |||
| return pageMap; | |||
| }; | |||
|
|
|||
| module.exports = (app, config) => { | |||
| module.exports = (app, config) => { | |||
| const gaTagId = config.gaTagId; | |||
There was a problem hiding this comment.
lots of linting issues
lib/ga-tag.js
Outdated
| res.locals.gaAllowDebug = config.env === 'development'; | ||
| res.locals.gaTagId = gaTagId; | ||
| res.locals.ga4TagId = ga4TagId; | ||
| res.locals.gtmTagId = gtmTagId | ||
| res.locals.appName = appName |
There was a problem hiding this comment.
why do you need the appName?
There was a problem hiding this comment.
I was using it before, but no longer need it. Good spot
- add environmentType template variable for pageLoad event
shamiluwais
approved these changes
Oct 6, 2023
- add validation that cookies are accepted before running GTM snippets
- move gtm snippet from body to head in gov-uk html template - validate cookies accepted before running gtm
…nd not other forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
pageLoadevents to track page visitsWhy?
How?
Testing?
Screenshots (optional)
Anything Else?