489 nodemailer smtp transport critical vulnerability fix v2 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves nested dep vuln GHSA-cf4h-3jhx-xvhq
- Removed the nodemailer-smtp-transport dependency as it is redundant and introduces a flagged critical vulnerability. - Updated CHANGELOG.md to reflect the changes.
|
Something has gone wrong the with original PR and branch so this new one was made, the original one is here which was created by @robertdeniszczyc2 and approved by me #494 (review) |
sulthan-ahmed
deleted the
489-nodemailer-smtp-transport-critical-vulnerability-fix-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves nested dep vuln GHSA-cf4h-3jhx-xvhq
What?
Replaces nodemailer-smtp-transport dep with nodemailer
Why?
If you consume HOF in a project building with npm, there is a nested dependency vulnerability flagged which is ranked "Critical". The vulnerability is:
Arbitrary Code Execution in underscore - GHSA-cf4h-3jhx-xvhq
The issue is in the version of underscore which is nested within the nodemailer-smtp-transport dependency
How?
Replaces nodemailer-smtp-transport dep with nodemailer
Testing?
yarn testhas been run locally, but will require testing for regressions on a real HOF project to check that emails work OKScreenshots (optional)
N/A
Anything Else? (optional)
See linked issue for more information
Check list
here is an example commit