This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
New domain unload fix. Reverting PR #2 changes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tak
added a commit
that referenced
this pull request
Sep 10, 2015
New domain unload fix. Reverting PR #2 changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #2 changes, as it had the unwanted side-effect of unloading all types in most cases.
This fix explicitly checks in GetType whether an mscorlib type has been unloaded in the debugger agent and returns null. The callers of GetType fall back to different approaches for getting the type if GetType returns null.
Fixes case 719009