Code

Apply static analysis suggestions#1201

Code

Merged

jcoupey merged 27 commits intomasterVROOM-Project/vroom:masterfrom enhancement/tidyVROOM-Project/vroom:enhancement/tidyCopy head branch name to clipboardDec 12, 2024

+446-474

Commits

Commits on Dec 10, 2024

• Constexpr inline is redundant.

  jcoupey

  committed
  a7ec8b3

  Copy full SHA for a7ec8b3

• Do not use alternative operators.

  jcoupey

  committed
  35338e6

  Copy full SHA for 35338e6

• Do not use size to check for emptyness.

  jcoupey

  committed
  8b460d2

  Copy full SHA for 8b460d2

• Use std::format in a couple places.

  jcoupey

  committed
  925c3ee

  Copy full SHA for 925c3ee

• Use default operator== whenever possible.

  jcoupey

  committed
  b8325fd

  Copy full SHA for b8325fd

• Remove nested if statements.

  jcoupey

  committed
  1c9c105

  Copy full SHA for 1c9c105

• Use raw string literal.

  jcoupey

  committed
  88711dc

  Copy full SHA for 88711dc

• Use a lambda instead of taking the address of library functions.

  jcoupey

  committed
  7ffe35a

  Copy full SHA for 7ffe35a

• Make sure to use operator |= with bool variables.

  jcoupey

  committed
  42b59cd

  Copy full SHA for 42b59cd

• Use transparent equality and hasher with std::unordered_set<std::string>.

  jcoupey

  committed
  1f9cf28

  Copy full SHA for 1f9cf28

• Handle part of the send_then_receive work in functions.

  jcoupey

  committed
  7869819

  Copy full SHA for 7869819

• Reduce duplication in ssl_send_then_receive.

  jcoupey

  committed
  b7574a4

  Copy full SHA for b7574a4

• Apply some readability fixes.

  jcoupey

  committed
  499ba86

  Copy full SHA for 499ba86

• Add pointer qualification to auto-typed variable deduced to pointer.

  jcoupey

  committed
  de07144

  Copy full SHA for de07144

• Use small underlying type for enums.

  jcoupey

  committed
  91f5e38

  Copy full SHA for 91f5e38

• Remove some headers.

  jcoupey

  committed
  6a30fb4

  Copy full SHA for 6a30fb4

Commits on Dec 11, 2024

• Replace iterator-based loop with some range stuff.

  jcoupey

  committed
  d1700d3

  Copy full SHA for d1700d3

• Update tidy rules.

  jcoupey

  committed
  5c43145

  Copy full SHA for 5c43145

• Const all the things!

  jcoupey

  committed
  0ca4451

  Copy full SHA for 0ca4451

• Explicit lambda capture.

  jcoupey

  committed
  aca2d5a

  Copy full SHA for aca2d5a

• Avoid superfluous const param in function declarations.

  jcoupey

  committed
  9870e04

  Copy full SHA for 9870e04

• Missing commas in clang-tidy config.

  jcoupey

  committed
  7328ff9

  Copy full SHA for 7328ff9

• Remove unused function.

  jcoupey

  committed
  e7ebca3

  Copy full SHA for e7ebca3

• Remove some magic numbers.

  jcoupey

  committed
  4909481

  Copy full SHA for 4909481

• Consistent parameter naming.

  jcoupey

  committed
  94a0dd3

  Copy full SHA for 94a0dd3

Commits on Dec 12, 2024

• Remove some more magic numbers.

  jcoupey

  committed
  16faa6c

  Copy full SHA for 16faa6c

• Mention tidying round in changelog.

  jcoupey

  committed
  485ee2b

  Copy full SHA for 485ee2b