Code

Fix PriorityReplace#1210

Code

Merged

jcoupey merged 13 commits intomasterVROOM-Project/vroom:masterfrom fix/invalid-priority-replaceVROOM-Project/vroom:fix/invalid-priority-replaceCopy head branch name to clipboardJan 29, 2025

+139-83

Commits

Commits on Jan 15, 2025

• Filter out invalid moves in PriorityReplace::is_valid.

  jcoupey

  committed
  ef298bf

  Copy full SHA for ef298bf

• Find valid smaller route start replacement if possible.

  jcoupey

  committed
  45313c8

  Copy full SHA for 45313c8

• Turn void start validity check into assertion.

  jcoupey

  committed
  1afbe66

  Copy full SHA for 1afbe66

Commits on Jan 16, 2025

• Account for assigned tasks when deciding about start or end replace.

  jcoupey

  committed
  230c182

  Copy full SHA for 230c182

• Find valid smaller route end replacement if possible.

  jcoupey

  committed
  b3379ca

  Copy full SHA for b3379ca

• Turn void end validity check into assertion.

  jcoupey

  committed
  b999d27

  Copy full SHA for b999d27

• Mention PriorityReplace fix.

  jcoupey

  committed
  d8c3c8a

  Copy full SHA for d8c3c8a

Commits on Jan 21, 2025

• Aim for net priority gains only in PriorityReplace.

  jcoupey

  committed
  d611763

  Copy full SHA for d611763

• Apply UnassignedExchange checks before PriorityReplace.

  jcoupey

  committed
  c234963

  Copy full SHA for c234963

• Expose resulting assigned number from PriorityReplace move.

  jcoupey

  committed
  fad9d8a

  Copy full SHA for fad9d8a

• Account for number of assigned tasks to pick best PriorityReplace move.

  jcoupey

  committed
  bdd3c20

  Copy full SHA for bdd3c20

• Account for number of removals to pick best priority-modifying move.

  jcoupey

  committed
  669989b

  Copy full SHA for 669989b

Commits on Jan 29, 2025

• Properly update best_removals.

  jcoupey

  committed
  1564f98

  Copy full SHA for 1564f98