Skip to content

Commit

Permalink
- Fixed Cursor style when hovering over menu buttons
Browse files Browse the repository at this point in the history
- Added Third Party Licenses Page
- Incremented Version to 1.1.0
  • Loading branch information
VarunS2002 committed Nov 9, 2020
1 parent 1a52f6b commit 05a13d2
Show file tree
Hide file tree
Showing 13 changed files with 606 additions and 30 deletions.
2 changes: 1 addition & 1 deletion tic-tac-toe/config.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version='1.0' encoding='utf-8'?>
<widget id="com.varuns2002.ttt" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:cdv="http://cordova.apache.org/ns/1.0">
<widget id="com.varuns2002.ttt" version="1.1.0" xmlns="http://www.w3.org/ns/widgets" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:cdv="http://cordova.apache.org/ns/1.0">
<name>Tic-Tac-Toe</name>
<description>A simple Tic-Tac-Toe game.</description>
<author email="shanbhag.varun@gmail.com" href="https://github.com/VarunS2002/">VarunS2002</author>
Expand Down
2 changes: 1 addition & 1 deletion tic-tac-toe/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tic-tac-toe/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "tic-tac-toe",
"version": "1.0.0",
"version": "1.1.0",
"author": "VarunS2002",
"homepage": "https://github.com/VarunS2002/",
"scripts": {
Expand Down
3 changes: 2 additions & 1 deletion tic-tac-toe/src/app/about/about.page.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<ion-content [fullscreen]="true">
<div id="icon">
<p class="title">Tic-Tac-Toe</p>
<p class="version">1.0.0</p>
<p class="version">1.1.0</p>
<a href="https://github.com/VarunS2002/" target="_blank" class="link">
<p class="profile">VarunS2002</p>
</a>
Expand All @@ -30,5 +30,6 @@
<a href="https://github.com/VarunS2002/Ionic-Tic-Tac-Toe/blob/main/LICENSE" target="_blank" class="link">
<p class="link">License</p>
</a>
<p class="link" (click)="licensesPageModal()" style="cursor: pointer">Third Party Licenses</p>
</div>
</ion-content>
9 changes: 9 additions & 0 deletions tic-tac-toe/src/app/about/about.page.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Component } from '@angular/core';
import { ModalController } from "@ionic/angular";
import { LicensesPage } from "../licenses/licenses.page";

@Component({
selector: 'app-about',
Expand All @@ -15,4 +16,12 @@ export class AboutPage {
// noinspection JSIgnoredPromiseFromCall
this.modalController.dismiss();
}

async licensesPageModal() {
const modal = await this.modalController.create({
component: LicensesPage,
cssClass: 'licenses-page'
});
return await modal.present();
}
}
52 changes: 29 additions & 23 deletions tic-tac-toe/src/app/app-routing.module.ts
Original file line number Diff line number Diff line change
@@ -1,26 +1,32 @@
import { NgModule } from '@angular/core';
import { PreloadAllModules, RouterModule, Routes } from '@angular/router';

const routes: Routes = [
{
path: 'home',
loadChildren: () => import('./home/home.module').then( m => m.HomePageModule)
},
{
path: '',
redirectTo: 'home',
pathMatch: 'full'
}, {
import { NgModule } from '@angular/core';
import { PreloadAllModules, RouterModule, Routes } from '@angular/router';

const routes: Routes = [
{
path: 'home',
loadChildren: () => import('./home/home.module').then( m => m.HomePageModule)
},
{
path: '',
redirectTo: 'home',
pathMatch: 'full'
},
{
path: 'about',
loadChildren: () => import('./about/about.module').then( m => m.AboutPageModule)
redirectTo: 'home',
pathMatch: 'full'
},
{
path: 'licenses',
redirectTo: 'home',
pathMatch: 'full'
},
];

];

@NgModule({
imports: [
RouterModule.forRoot(routes, { preloadingStrategy: PreloadAllModules })
],
exports: [RouterModule]
})
export class AppRoutingModule { }
@NgModule({
imports: [
RouterModule.forRoot(routes, { preloadingStrategy: PreloadAllModules })
],
exports: [RouterModule]
})
export class AppRoutingModule { }
6 changes: 3 additions & 3 deletions tic-tac-toe/src/app/home/home.page.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
</ion-toolbar>
</ion-header>
<ion-content>
<ion-item (click)="setTheme(false)" class="ion-activatable" style="margin-left: -15px">
<ion-item (click)="setTheme(false)" class="ion-activatable" style="margin-left: -15px;cursor: pointer">
&nbsp;&nbsp;&nbsp;&nbsp;
<ion-icon name="contrast-sharp"></ion-icon>
<ion-label>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Switch Theme</ion-label>
<ion-ripple-effect></ion-ripple-effect>
</ion-item>
<ion-item (click)="goTo('about')" class="ion-activatable" style="margin-left: -15px">
<ion-item (click)="goTo('about')" class="ion-activatable" style="margin-left: -15px;cursor: pointer">
&nbsp;&nbsp;&nbsp;&nbsp;
<ion-icon name="help-outline"></ion-icon>
<ion-label>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;About</ion-label>
<ion-ripple-effect></ion-ripple-effect>
</ion-item>
<ion-item *ngIf="!isBrowser" (click)="alertExit()" class="ion-activatable" style="margin-left: -15px">
<ion-item *ngIf="!isBrowser" (click)="alertExit()" class="ion-activatable" style="margin-left: -15px;cursor: pointer">
&nbsp;&nbsp;&nbsp;&nbsp;
<ion-icon name="arrow-back"></ion-icon>
<ion-label>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Exit</ion-label>
Expand Down
17 changes: 17 additions & 0 deletions tic-tac-toe/src/app/licenses/licenses-routing.module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { LicensesPage } from './licenses.page';

const routes: Routes = [
{
path: '',
component: LicensesPage
}
];

@NgModule({
imports: [RouterModule.forChild(routes)],
exports: [RouterModule],
})
export class LicensesPageRoutingModule {}
20 changes: 20 additions & 0 deletions tic-tac-toe/src/app/licenses/licenses.module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { FormsModule } from '@angular/forms';

import { IonicModule } from '@ionic/angular';

import { LicensesPageRoutingModule } from './licenses-routing.module';

import { LicensesPage } from './licenses.page';

@NgModule({
imports: [
CommonModule,
FormsModule,
IonicModule,
LicensesPageRoutingModule
],
declarations: [LicensesPage]
})
export class LicensesPageModule {}
Loading

0 comments on commit 05a13d2

Please sign in to comment.