docs:theme config explanation 11-1 #3535 #3629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xile611
reviewed
Jan 14, 2025
| - `_spec.theme`：用户在图表 spec 对象配置中指定的主题 | ||
| - `_currentThemeName`：通过 `VChart.ThemeManager.registerTheme` 注册的当前全局主题名称 | ||
|
|
||
| ### 简析主题合并的逻辑 (util/theme/merge-theme.ts) |
There was a problem hiding this comment.
源码解析可以单独列一章节，然后通过一个简单的流程图作为整体流程介绍，然后分析每个细节
|
|
||
| ```typescript | ||
| export function mergeTheme(target: Maybe<ITheme>, ...sources: Maybe<ITheme>[]): Maybe<ITheme> { | ||
| return mergeSpec(transformThemeToMerge(target), ...sources.map(transformThemeToMerge)); |
There was a problem hiding this comment.
这里没有体现 transformThemeToMerge 做了哪些处理
| } | ||
| ``` | ||
|
|
||
| todo: rgbToHsl hslToRgb 的分析 |
There was a problem hiding this comment.
您好，最新的更改我更新在飞书文档 :https://papergames.feishu.cn/docx/EyJQd5WwxoYB97xWXpGc4VNAnRg 啦，完成好了转md再翻译再提pr
Shabi-x
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Shabi-x
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough