Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Remove verify2.Locale enum #499

Merged
merged 1 commit into from
Nov 30, 2023
Merged

breaking: Remove verify2.Locale enum #499

merged 1 commit into from
Nov 30, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Nov 30, 2023

Due to the complexities of locales in Verify v2, this PR removes the hardcoded enums from VerificationRequest altogether in favour of java.util.Locale.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Merging #499 (f4ad765) into main (1de01a9) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #499      +/-   ##
============================================
- Coverage     94.66%   94.61%   -0.05%     
+ Complexity     2863     2862       -1     
============================================
  Files           423      422       -1     
  Lines          6949     6911      -38     
  Branches        439      440       +1     
============================================
- Hits           6578     6539      -39     
  Misses          200      200              
- Partials        171      172       +1     
Files Coverage Δ
...com/vonage/client/verify2/VerificationRequest.java 98.43% <75.00%> (-1.57%) ⬇️

@SMadani SMadani merged commit 07afa55 into main Nov 30, 2023
11 checks passed
@SMadani SMadani deleted the verify2-locales branch November 30, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants