Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new properties to Messages API #504

Merged
merged 11 commits into from
Jan 4, 2024
Merged

feat: Add new properties to Messages API #504

merged 11 commits into from
Jan 4, 2024

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Jan 2, 2024

Various updates to reflect recent changes in the Messages v1 spec. Description of these is in each commit headline.

@SMadani SMadani marked this pull request as ready for review January 2, 2024 18:54
@SMadani SMadani requested a review from superchilled January 2, 2024 18:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Merging #504 (d8352de) into main (8cdb975) will decrease coverage by 0.13%.
The diff coverage is 85.98%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #504      +/-   ##
============================================
- Coverage     94.34%   94.22%   -0.13%     
- Complexity     2755     2797      +42     
============================================
  Files           399      405       +6     
  Lines          6651     6748      +97     
  Branches        436      444       +8     
============================================
+ Hits           6275     6358      +83     
  Misses          203      203              
- Partials        173      187      +14     
Files Coverage Δ
...ava/com/vonage/client/messages/MessageRequest.java 97.56% <100.00%> (+0.68%) ⬆️
...va/com/vonage/client/messages/MessagesVersion.java 100.00% <100.00%> (ø)
...onage/client/messages/internal/MessagePayload.java 94.28% <100.00%> (+0.73%) ⬆️
...om/vonage/client/messages/mms/MmsAudioRequest.java 100.00% <100.00%> (ø)
...om/vonage/client/messages/mms/MmsImageRequest.java 100.00% <100.00%> (ø)
...ava/com/vonage/client/messages/mms/MmsRequest.java 100.00% <100.00%> (ø)
...om/vonage/client/messages/mms/MmsVcardRequest.java 100.00% <100.00%> (ø)
...om/vonage/client/messages/mms/MmsVideoRequest.java 100.00% <100.00%> (ø)
...com/vonage/client/messages/sms/SmsTextRequest.java 100.00% <100.00%> (ø)
...a/com/vonage/client/messages/whatsapp/Context.java 100.00% <ø> (ø)
... and 8 more

Copy link

@superchilled superchilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just wanted to check a couple of things because I couldn't see them in the changed files:

  • For WhatsApp Inbound (all message types) add context.message_uuid and context.message_from
  • For Viber Outbound (type video) add viber_service.duration and viber_service.file_size

Maybe you already updated these properties prior to this PR?

@SMadani
Copy link
Contributor Author

SMadani commented Jan 4, 2024

Looks good overall. Just wanted to check a couple of things because I couldn't see them in the changed files:

  • For WhatsApp Inbound (all message types) add context.message_uuid and context.message_from
  • For Viber Outbound (type video) add viber_service.duration and viber_service.file_size

Maybe you already updated these properties prior to this PR?

Yep, they've been in the spec for a while and hence the SDK :)

@SMadani SMadani requested a review from superchilled January 4, 2024 12:34
@SMadani SMadani merged commit fc884ba into main Jan 4, 2024
12 checks passed
@SMadani SMadani deleted the messages-updates branch January 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants