-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new properties to Messages API #504
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
============================================
- Coverage 94.34% 94.22% -0.13%
- Complexity 2755 2797 +42
============================================
Files 399 405 +6
Lines 6651 6748 +97
Branches 436 444 +8
============================================
+ Hits 6275 6358 +83
Misses 203 203
- Partials 173 187 +14
|
d34f7a2
to
d8352de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just wanted to check a couple of things because I couldn't see them in the changed files:
- For WhatsApp Inbound (all message types) add
context.message_uuid
andcontext.message_from
- For Viber Outbound (type
video
) addviber_service.duration
andviber_service.file_size
Maybe you already updated these properties prior to this PR?
Yep, they've been in the spec for a while and hence the SDK :) |
Various updates to reflect recent changes in the Messages v1 spec. Description of these is in each commit headline.