Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing NCCO fields #510

Merged
merged 6 commits into from
Jan 17, 2024
Merged

feat: Add missing NCCO fields #510

merged 6 commits into from
Jan 17, 2024

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Jan 17, 2024

A fair few fields are not present in the NCCO actions in com.vonage.client.voice.ncco. This PR updates them to be consistent with the NCCO reference documentation, along with improved documentation. It also achieves 100% coverage for Voice, since the VoiceResponseException wasn't covered in VoiceClientTest.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Merging #510 (7967b67) into main (b5179f6) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #510      +/-   ##
============================================
+ Coverage     95.21%   95.33%   +0.11%     
- Complexity     2895     2934      +39     
============================================
  Files           427      428       +1     
  Lines          6880     6983     +103     
  Branches        393      407      +14     
============================================
+ Hits           6551     6657     +106     
+ Misses          201      198       -3     
  Partials        128      128              
Files Coverage Δ
...va/com/vonage/client/voice/ncco/ConnectAction.java 100.00% <100.00%> (ø)
...m/vonage/client/voice/ncco/ConversationAction.java 100.00% <100.00%> (ø)
...java/com/vonage/client/voice/ncco/InputAction.java 100.00% <ø> (ø)
...ava/com/vonage/client/voice/ncco/NotifyAction.java 100.00% <100.00%> (ø)
...ava/com/vonage/client/voice/ncco/RecordAction.java 100.00% <100.00%> (ø)
...a/com/vonage/client/voice/ncco/SpeechSettings.java 100.00% <100.00%> (ø)
...onage/client/voice/ncco/TranscriptionSettings.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@SMadani SMadani merged commit 18389ef into main Jan 17, 2024
12 checks passed
@SMadani SMadani deleted the conversation-ncco branch January 17, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants