add integrated terminal support #447
Conversation
| # prefer using tail to detect PID exit, but that requires GNU tail | ||
| tail -f --pid=${process.pid} /dev/null 2>/dev/null || while kill -s 0 ${process.pid} 2>/dev/null; do sleep 1s; done |
There was a problem hiding this comment.
Does this mean you consider the PR unfinished / a working draft?
| tty > ${ttyTmpDir}/ttynameTmp | ||
| mv ${ttyTmpDir}/ttynameTmp ${ttyTmpDir}/ttyname |
There was a problem hiding this comment.
Just fo0r understanding: Is the first command slow and the mv is used to ensure it is finished before it is available under the name?
There was a problem hiding this comment.
The use of mv in this context is not primarily to address slowness but to ensure atomicity and consistency, preventing the watcher from observing a file that is being written to halfway through the process.
| `#!/usr/bin/env sh | ||
| # reset terminal to clear any previous states | ||
| reset |
There was a problem hiding this comment.
This uses the shell's init commands, no?
Should this be suppressed? Should there be an option to add extra commands?
| if(this.application.includes('gdb')){ | ||
| this.emit("debug-ready"); | ||
| } |
There was a problem hiding this comment.
So no debug-ready for non GDB scenarios and none for win-32 any more?!?
There was a problem hiding this comment.
For now, that's the situation. In the future, we can try to add more, but it might involve more work.
| @@ -4,7 +4,7 @@ import * as fs from "fs"; | |||
| export function spawnTerminalEmulator(preferedEmulator: string): Thenable<string> { | |||
| return new Promise((resolve, reject) => { | |||
| const ttyFileOutput = "/tmp/vscode-gdb-tty-0" + Math.floor(Math.random() * 100000000).toString(36); | |||
| ChildProcess.spawn(preferedEmulator || "x-terminal-emulator", ["-e", "sh -c \"tty > " + ttyFileOutput + " && sleep 4294967294\""]); | |||
There was a problem hiding this comment.
Shouldn't we still provide the option to use a preferedEmulator?
| public async createIntegratedTerminalLinux(args:DebugProtocol.RunInTerminalRequestArguments) { | ||
| const mkdirAsync = fs.promises.mkdir; | ||
| const mkdtempAsync = async (tempDir: string, prefix: string): Promise<string> => { | ||
| const name = `${prefix}-${Date.now()}-${Math.floor(Math.random() * 1e9)}`; |
There was a problem hiding this comment.
What about using the same approach as above for the tempName?
Math.floor(Math.random() * 100000000).toString(36)
There was a problem hiding this comment.
thanks, i will fix this
| @@ -24,6 +24,7 @@ Versioning]. | |||
| - solve the problem of failed parsing of containers ([@henryriley0]) | |||
| - Fixes #421 - Added `registerLimit` option to specify the registers to | |||
| display - PR #444 ([@chenzhiy2001]) | |||
| - add integrated terminal support ([@henryriley0]) | |||
Set the default input and output in the VSCode terminal, SSH is not supported for now.