Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog checker #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add changelog checker #38

wants to merge 1 commit into from

Conversation

ClementPinard
Copy link
Collaborator

Pull Request

Describe your changes

Add changelog Checker action that fails when a PR is submitted without change in the CHANGELOG.md

The action is not run if the PR is labelled "dependencies" so that dependabot and pre-commit PR won't fail.

I have deliberately left the CHANGELOG untouched to see how the action would behave.

Issue number if applicable

Checklist before requesting a review

Github actions will check that these tasks were performed but it will reduce friction if you deal with them beforhand

  • If code is added, the new lines are covered by tests (Checked by Codecov)
  • Type hints are consistent (Checked by pyright Job)
  • Code style follows black conventions (Checked by pre-commit)
  • If documentation is added, it does not raise a warning in sphinx (checked by sphinx-build)
  • CHANGELOG has been updated if applicable

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@ClementPinard ClementPinard force-pushed the CI/check_changelog branch 4 times, most recently from 6893e05 to f721c61 Compare September 27, 2024 14:50
@ClementPinard
Copy link
Collaborator Author

ClementPinard commented Sep 27, 2024

PR on hold for the moment, as no satisfying actions can be found.

I created an issue for the most promising one, because it lets you chose which label to ignore and posts a comment afterward, but right now outputs a syntaxe error

GiulioRomualdi/yet-another-changelog-checker#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant