-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update geo-types to 0.7.8 #1032
Update geo-types to 0.7.8 #1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! When I run cargo check
, I get a handful of use of deprecated type alias
geo::Coordinate: Renamed to
geo_types::Coord(or
geo::Coord)
warnings. Would you mind fixing those up too?
I'll have a look through the good first issues tomorrow and make sure they're up-to-date. Any particular interest in a part of the project (like 15-minute neighbourhoods, or the traffic simulation) or a preference about the type of code (OpenStreetMap processing, more standard web dev, new features involving the UI code)?
Sure thing
not really, the entire project looks interesting!
I was looking for a cool open-source project to contribute to while improving my Rust skills. My expertise lies in web dev though, so I'd say mostly Rust interspersed with web dev things when I need to give my brain a break from learning a new language. If you have any needs related to GitHub actions, I can definitely help with that. I'm thinking the issue solved here may have not been seen because the actions rely on a stale cache? Perhaps a nightly workflow that resets the cache would solve that? Re. how much I'm looking to contribute, in case you're wondering: I'm currently an Engineering Partner with Commit, meaning that I have time to contribute to any project of my choosing to improve my skills, but I may be joining a startup anytime soon, so I don't know how long I'll be available to contribute. |
What version of rust were you using when you hit that error? I'd only expect to see it affecting nightly at this point. |
Ah, yes, I am using nightly
|
Should I open an issue/PR to add a |
Not sure I've seen many projects specify
No workflow builds everything on every commit right now. The project is small enough to make that unnecessary; there've never been more than a few people working on it at a time. There's a release process that's a bit manual, but isn't worth automating further right now.
A sampling of ideas, then... let me know if more context is useful for any of them
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the build fix!
On a new dev build, compiling fails due to the following error:
This issue was fixed in geo-types 0.7.8, so I updated it using
cargo update --package geo-types
.Side note: I am looking into contributing to this project over the next few weeks. I'll take a look at those good first issues and see if I can open more PRs. Happy to hear any suggestions you might have re. where to start!