Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geo-types to 0.7.8 #1032

Merged

Conversation

matthieu-foucault
Copy link
Contributor

On a new dev build, compiling fails due to the following error:

   Compiling geo-types v0.7.7
error: expected `,`, found `.`
   --> /home/matthieu/.cargo/registry/src/github.com-1ecc6299db9ec823/geo-types-0.7.7/src/geometry/geometry_collection.rs:111:25
    |
111 | #[deprecated(since = 0.7.5, note = "Use `GeometryCollection::from(vec![geom])` instead.")]
    |                         ^ expected `,`

This issue was fixed in geo-types 0.7.8, so I updated it using cargo update --package geo-types.

Side note: I am looking into contributing to this project over the next few weeks. I'll take a look at those good first issues and see if I can open more PRs. Happy to hear any suggestions you might have re. where to start!

Copy link
Collaborator

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! When I run cargo check, I get a handful of use of deprecated type alias geo::Coordinate: Renamed to geo_types::Coord(orgeo::Coord) warnings. Would you mind fixing those up too?

I'll have a look through the good first issues tomorrow and make sure they're up-to-date. Any particular interest in a part of the project (like 15-minute neighbourhoods, or the traffic simulation) or a preference about the type of code (OpenStreetMap processing, more standard web dev, new features involving the UI code)?

@matthieu-foucault
Copy link
Contributor Author

Would you mind fixing those up too?

Sure thing

Any particular interest?

not really, the entire project looks interesting!

a preference about the type of code

I was looking for a cool open-source project to contribute to while improving my Rust skills. My expertise lies in web dev though, so I'd say mostly Rust interspersed with web dev things when I need to give my brain a break from learning a new language.

If you have any needs related to GitHub actions, I can definitely help with that. I'm thinking the issue solved here may have not been seen because the actions rely on a stale cache? Perhaps a nightly workflow that resets the cache would solve that?

Re. how much I'm looking to contribute, in case you're wondering: I'm currently an Engineering Partner with Commit, meaning that I have time to contribute to any project of my choosing to improve my skills, but I may be joining a startup anytime soon, so I don't know how long I'll be available to contribute.

@michaelkirk
Copy link
Collaborator

What version of rust were you using when you hit that error? I'd only expect to see it affecting nightly at this point.

@matthieu-foucault
Copy link
Contributor Author

Ah, yes, I am using nightly

$ rustup show

active toolchain
----------------

nightly-x86_64-unknown-linux-gnu (default)
rustc 1.67.0-nightly (b3bc6bf31 2022-11-24)

@matthieu-foucault
Copy link
Contributor Author

Should I open an issue/PR to add a toolchain.toml file?

@dabreegster
Copy link
Collaborator

Should I open an issue/PR to add a toolchain.toml file?

Not sure I've seen many projects specify toolchain.toml for stable, but it'd be fine to codify the docs (which're outdated... latest stable, not 1.61)

I'm thinking the issue solved here may have not been seen because the actions rely on a stale cache? Perhaps a nightly workflow that resets the cache would solve that?

No workflow builds everything on every commit right now. The project is small enough to make that unnecessary; there've never been more than a few people working on it at a time. There's a release process that's a bit manual, but isn't worth automating further right now.

not really, the entire project looks interesting!

A sampling of ideas, then... let me know if more context is useful for any of them

Copy link
Collaborator

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the build fix!

@dabreegster dabreegster merged commit aa40be4 into a-b-street:master Dec 6, 2022
@matthieu-foucault matthieu-foucault deleted the fix/update-geo-types branch December 6, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants