Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeplink query parameters user details validation improvement #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kariot
Copy link

@kariot kariot commented Nov 12, 2024

Added validation to the user object received via the deep link. It already checks for the presence of the user object, but it could still be empty in sign-in scenarios and interrupt the sign-in flow due to JSON decode error.

 - Validation improved for user details object received via deeplink
@kariot kariot requested review from tp and HenriBeck as code owners November 12, 2024 09:14
@tp
Copy link
Collaborator

tp commented Nov 12, 2024

@kariot Sorry, for the initial response. I got this mixed up and read it as a bug report and not a PR…

Where you able to capture the incoming deep link to show how it's not matching expectations?

Was it really contains user= instead of no user parameter at all? Just surprised, because
per the documentation at https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_js/incorporating_sign_in_with_apple_into_other_platforms I would always expect it in a non-error case:

CleanShot 2024-11-12 at 13 28 26@2x

But maybe there is a case, e.g. when not requesting any scopes, when it will be absent?

@tp tp closed this Nov 12, 2024
@tp tp reopened this Nov 12, 2024
@kariot
Copy link
Author

kariot commented Nov 12, 2024

Hi @tp,

I've noticed the issue where I was receiving an empty user object—meaning the user key is present, but it has no associated value. I was able to reproduce this by signing up from an iOS device and then signing in from an Android device, which seems to cause a crash.

@tp tp changed the title Deeplink query paramerters user details validation improvment Deeplink query parameters user details validation improvement Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants