make auto.output call both speak and braille #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix auto.output to call output
EphDoering
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple issues preventing
auto.outputfrom working as documented. First, it only called speak, so braille was never output. Second when I switched to calling.outputI discovered thatbase.outputalways raised an error even when the calls to speak and braille were successful. This is because python returns None by default which evaluated to False in the if statements. By explicitly checking for False I believe I retained the original intent of the function and now auto.output works for all of the output classes that I tested and will likely work for them all.I believe this would close #19, at least for their sample code.