Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dayperiod segment no longer resets when hour deleted #7506

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

charlotte-whiting
Copy link

@charlotte-whiting charlotte-whiting commented Dec 11, 2024

Closes #6793

✅ Pull Request Checklist:

  • [x ] Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Run locally
Test it either in the storybook or docs (can test in timefield, datefield, datepicker)
Make sure the dayperiod is set to PM
Delete the hour
Day period should not change

🧢 Your Project:

@yihuiliao
Copy link
Member

Thanks for the PR! It seems like you've run prettier or something similar over the file which has created a lot of noise and fails lint. Would you mind undoing that so it's easier to review the actual change?

@charlotte-whiting
Copy link
Author

Sorry about that @yihuiliao ! I think I got that fixed now

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait! The changes look good, I just added a test which I hope you don't mind. I'll get others to review but thanks for being patient!

@charlotte-whiting
Copy link
Author

Thank you! This was my first contribution so thanks for adding the test, I'll keep it in mind for the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeField resets dayPeriod segment when hour value is deleted
2 participants