Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect padding and remove cursor in DateRangePicker #7712

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Feb 3, 2025

Fixes stuff from testing.

In FF, in the DateRangePicker Granularity Second story, if you tab to the DateRangePicker, a cursor will appear.
Screenshot 2025-02-03 at 3 43 18 PM

In Safari, between the dash separating the two datefields and the rightmost datefield, there's supposed to be padding but it appears to be missing.

Screenshot 2025-02-03 at 1 16 33 PM

see chromatic: https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=885

there seems to be one minor change which is the thickness of the dash in daterangepicker only in hebrew tho. i don't think that change is that bad for the tradeoffs we get.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Make sure the two issues above are fixed and that the date/time formats are still in the correct order.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 3, 2025

@yihuiliao yihuiliao added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit eae712a Feb 4, 2025
35 checks passed
@yihuiliao yihuiliao deleted the fix-daterangepicker branch February 4, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants