Merge pull request #547 from jelhan/support-ember-v4

Support Ember v5
adopted-ember-addons · Nov 29, 2024 · cb4ec4f · cb4ec4f
2 parents 3eed3b4 + aca19c4
commit cb4ec4f
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -59,6 +59,7 @@ jobs:
         try-scenario:
           - ember-lts-3.28
           - ember-lts-4.12
+          - ember-lts-5.12
           - ember-classic
           # - ember-release
           # - ember-beta

diff --git a/package.json b/package.json
@@ -123,12 +123,14 @@
     "typescript": "^4.4.3",
     "webpack": "^5.78.0"
   },
-  "resolutions": {
-    "@babel/plugin-transform-modules-amd": "7.16.5"
-  },
   "peerDependencies": {
+    "@ember/string": ">= 3.0.0",
     "ember-source": ">= 3.28.0"
   },
+  "resolutions": {
+    "@babel/plugin-transform-modules-amd": "7.16.5",
+    "@ember/string": "^4.0.0"
+  },
   "engines": {
     "node": "18.* || 20.* || >= 22"
   },

diff --git a/tests/dummy/config/ember-try.js b/tests/dummy/config/ember-try.js
@@ -23,6 +23,15 @@ module.exports = async function () {
           },
         },
       },
+      {
+        name: 'ember-lts-5.12',
+        npm: {
+          devDependencies: {
+            'ember-resolver': '^12.0.0',
+            'ember-source': '~5.12.0',
+          },
+        },
+      },
       {
         name: 'ember-release',
         npm: {

diff --git a/yarn.lock b/yarn.lock
@@ -984,6 +984,11 @@
   dependencies:
     ember-cli-babel "^7.26.6"
 
+"@ember/string@^4.0.0":
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/@ember/string/-/string-4.0.0.tgz#24fe5cda227c9e6634e6e0b550944a3a13437878"
+  integrity sha512-IMVyVE72twuAMSYcHzWSgtgYTtzlHlKSGW8vEbztnnmkU6uo7kVHmiqSN9R4RkBhzvh0VD4G76Eph+55t3iNIA==
+
 "@ember/test-helpers@*":
   version "4.0.4"
   resolved "https://registry.yarnpkg.com/@ember/test-helpers/-/test-helpers-4.0.4.tgz#2ffb55c8438b8ba54ecd4f546059ba0166bc00f2"