Skip to content

Commit

Permalink
Remove SyncDebug from VimBroker
Browse files Browse the repository at this point in the history
This is a tool for debugging concurrency issues that is left commented
out and never used, but depends on a tool in manageiq-gems-pending that
we are looking to remove.

Closes ManageIQ#54
  • Loading branch information
agrare committed Mar 28, 2019
1 parent a03d3a1 commit c49c5fc
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 253 deletions.
9 changes: 0 additions & 9 deletions lib/VMwareWebService/MiqVimBroker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ def new_with(uri, ref)
require 'timeout'
require 'VMwareWebService/broker_timeout'

# Un-comment following 2 lines to enable Sync lock debugging.
# require 'broker_sync_debug'
# extend BrokerSyncDebug

unless @@classModed
DRb.instance_variable_set(:@mutex, sync_for_drb)
DRb::DRbConn.instance_variable_set(:@mutex, sync_for_drb_drbconn)
Expand Down Expand Up @@ -107,27 +103,22 @@ def new_with(uri, ref)
end
end

# Can be overridden by BrokerSyncDebug.
def connection_lock
Sync.new
end

# Can be overridden by BrokerSyncDebug.
def config_lock
Sync.new
end

# Can be overridden by BrokerSyncDebug.
def sync_for_lock_hash(_key)
Sync.new
end

# Can be overridden by BrokerSyncDebug.
def sync_for_drb_drbconn
Sync.new
end

# Can be overridden by BrokerSyncDebug.
def sync_for_drb
Sync.new
end
Expand Down
4 changes: 0 additions & 4 deletions lib/VMwareWebService/MiqVimInventory.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require 'VMwareWebService/VimSyncDebug'
require 'sync'
require 'enumerator'
require 'VMwareWebService/MiqVimClientBase'
Expand Down Expand Up @@ -94,9 +93,6 @@ def initialize(server, username, password, cacheScope = nil)
@cacheLock = Sync.new
@configLock = Sync.new

# Un-comment to enable Sync lock debugging.
# extend VimSyncDebug

resetCache
__connect
@alive = true
Expand Down
16 changes: 0 additions & 16 deletions lib/VMwareWebService/VimSyncDebug.rb

This file was deleted.

33 changes: 0 additions & 33 deletions lib/VMwareWebService/broker_sync_debug.rb

This file was deleted.

68 changes: 0 additions & 68 deletions lib/VMwareWebService/vim_base_sync_debug.rb

This file was deleted.

123 changes: 0 additions & 123 deletions test/VMwareWebService/brokerLoadTest.rb

This file was deleted.

0 comments on commit c49c5fc

Please sign in to comment.