Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mempool filters and builder affinity #989

Open
wants to merge 1 commit into
base: danc/submit-proxy
Choose a base branch
from

Conversation

dancoombs
Copy link
Collaborator

Closes #982

bin/rundler/src/cli/mod.rs Outdated Show resolved Hide resolved
crates/pool/src/task.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 50.83799% with 88 lines in your changes missing coverage. Please review.

Project coverage is 59.08%. Comparing base (b5e0311) to head (5fbe784).

Files with missing lines Patch % Lines
crates/builder/src/emit.rs 27.02% 27 Missing ⚠️
crates/builder/src/task.rs 0.00% 10 Missing ⚠️
crates/pool/src/task.rs 0.00% 9 Missing ⚠️
crates/sim/src/simulation/mempool.rs 50.00% 9 Missing ⚠️
bin/rundler/src/cli/mod.rs 0.00% 7 Missing ⚠️
crates/builder/src/bundle_proposer.rs 80.00% 5 Missing ⚠️
crates/pool/src/server/local.rs 0.00% 5 Missing ⚠️
crates/pool/src/server/remote/protos.rs 0.00% 5 Missing ⚠️
crates/pool/src/server/remote/server.rs 0.00% 4 Missing ⚠️
bin/rundler/src/cli/builder.rs 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/mod.rs 100.00% <100.00%> (ø)
crates/pool/src/mempool/paymaster.rs 93.75% <100.00%> (+<0.01%) ⬆️
crates/pool/src/mempool/pool.rs 96.99% <100.00%> (+<0.01%) ⬆️
crates/pool/src/mempool/uo_pool.rs 92.62% <100.00%> (+0.05%) ⬆️
crates/rpc/src/eth/api.rs 71.92% <100.00%> (+0.09%) ⬆️
crates/types/src/pool/traits.rs 100.00% <ø> (ø)
crates/types/src/pool/types.rs 45.00% <ø> (ø)
crates/pool/src/server/remote/client.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
crates/builder/src/bundle_sender.rs 73.51% <70.00%> (ø)
... and 9 more
Flag Coverage Δ
unit-tests 59.08% <50.83%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 65.41% <45.12%> (-0.24%) ⬇️
dev ∅ <ø> (∅)
pool 67.26% <64.70%> (-0.09%) ⬇️
provider 19.10% <ø> (ø)
rpc 26.51% <100.00%> (+0.03%) ⬆️
sim 77.34% <50.00%> (-0.09%) ⬇️
tasks ∅ <ø> (∅)
types 68.82% <ø> (ø)
utils 30.06% <ø> (ø)

@dancoombs dancoombs force-pushed the danc/affinity branch 2 times, most recently from ce42feb to 6793bb8 Compare February 1, 2025 17:55
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally looks good, I just think there should be some tests added

@@ -1022,9 +1028,9 @@ mod tests {
.add_operation(OperationOrigin::Local, op.op)
.await
.unwrap();
check_ops(pool.best_operations(1, 0).unwrap(), uos);
check_ops(pool.best_operations(1, 0, None).unwrap(), uos);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see a test using the filter_id, do we want to add one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants