-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mempool filters and builder affinity #989
Open
dancoombs
wants to merge
1
commit into
danc/submit-proxy
Choose a base branch
from
danc/affinity
base: danc/submit-proxy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour,
alex-miao and
andysim3d
as code owners
February 1, 2025 17:35
dancoombs
commented
Feb 1, 2025
dancoombs
commented
Feb 1, 2025
dancoombs
force-pushed
the
danc/affinity
branch
2 times, most recently
from
February 1, 2025 17:55
ce42feb
to
6793bb8
Compare
dancoombs
force-pushed
the
danc/affinity
branch
from
February 1, 2025 18:22
6793bb8
to
5fbe784
Compare
0xfourzerofour
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overally looks good, I just think there should be some tests added
@@ -1022,9 +1028,9 @@ mod tests { | |||
.add_operation(OperationOrigin::Local, op.op) | |||
.await | |||
.unwrap(); | |||
check_ops(pool.best_operations(1, 0).unwrap(), uos); | |||
check_ops(pool.best_operations(1, 0, None).unwrap(), uos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see a test using the filter_id, do we want to add one?
andysim3d
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #982