fix: Ensuring filtering works for ASA and Asset txns

docs/code/interfaces/types_subscription.TransactionFilter.md

@@ -117,7 +117,7 @@ ___
 • `Optional` **maxAmount**: `number`
 
 Filter to transactions where the amount being transferred is less than
-or equal to the given maximum (microAlgos or decimal units of an ASA).
+or equal to the given maximum (microAlgos or decimal units of an ASA if type: axfer).
 
 #### Defined in
 
@@ -143,7 +143,7 @@ ___
 • `Optional` **minAmount**: `number`
 
 Filter to transactions where the amount being transferred is greater
-than or equal to the given minimum (microAlgos or decimal units of an ASA).
+than or equal to the given minimum (microAlgos or decimal units of an ASA if type: axfer).
 
 #### Defined in
 

docs/subscriptions.md

@@ -88,10 +88,10 @@ export interface TransactionFilter {
   /** Filter to transactions that are creating an asset. */
   assetCreate?: boolean
   /** Filter to transactions where the amount being transferred is greater
-   * than or equal to the given minimum (microAlgos or decimal units of an ASA). */
+   * than or equal to the given minimum (microAlgos or decimal units of an ASA if type: axfer). */
   minAmount?: number
   /** Filter to transactions where the amount being transferred is less than
-   * or equal to the given maximum (microAlgos or decimal units of an ASA). */
+   * or equal to the given maximum (microAlgos or decimal units of an ASA  if type: axfer). */
   maxAmount?: number
   /** Filter to app transactions that have the given ARC-0004 method selector for
    * the given method signature as the first app argument. */

src/subscriptions.ts

@@ -139,7 +139,7 @@ function indexerPreFilter(
       filter = filter.txType(subscription.type.toString())
     }
     if (subscription.notePrefix) {
-      filter = filter.notePrefix(subscription.notePrefix)
+      filter = filter.notePrefix(Buffer.from(subscription.notePrefix).toString('base64'))
     }
     if (subscription.appId) {
       filter = filter.applicationID(subscription.appId)
@@ -210,7 +210,7 @@ function transactionFilter(
       result &&= !!t.from && encodeAddress(t.from.publicKey) === subscription.sender
     }
     if (subscription.receiver) {
-      result &&= !!t.to && encodeAddress(t.to.publicKey) === subscription.sender
+      result &&= !!t.to && encodeAddress(t.to.publicKey) === subscription.receiver
     }
     if (subscription.type) {
       result &&= t.type === subscription.type

src/transform.ts

@@ -139,11 +139,13 @@ export function getIndexerTransactionFromAlgodTransaction(
                   'default-frozen': transaction.assetDefaultFrozen,
                   'metadata-hash': transaction.assetMetadataHash,
                   name: transaction.assetName,
-                  'name-b64': encoder.encode(Buffer.from(transaction.assetName).toString('base64')),
+                  'name-b64': transaction.assetName ? encoder.encode(Buffer.from(transaction.assetName).toString('base64')) : undefined,
                   'unit-name': transaction.assetUnitName,
-                  'unit-name-b64': encoder.encode(Buffer.from(transaction.assetUnitName).toString('base64')),
+                  'unit-name-b64': transaction.assetUnitName
+                    ? encoder.encode(Buffer.from(transaction.assetUnitName).toString('base64'))
+                    : undefined,
                   url: transaction.assetURL,
-                  'url-b64': encoder.encode(Buffer.from(transaction.assetURL).toString('base64')),
+                  'url-b64': transaction.assetURL ? encoder.encode(Buffer.from(transaction.assetURL).toString('base64')) : undefined,
                   manager: transaction.assetManager ? algosdk.encodeAddress(transaction.assetManager.publicKey) : undefined,
                   reserve: transaction.assetReserve ? algosdk.encodeAddress(transaction.assetReserve.publicKey) : undefined,
                   clawback: transaction.assetClawback ? algosdk.encodeAddress(transaction.assetClawback.publicKey) : undefined,

src/types/subscription.ts

@@ -64,10 +64,10 @@ export interface TransactionFilter {
   /** Filter to transactions that are creating an asset. */
   assetCreate?: boolean
   /** Filter to transactions where the amount being transferred is greater
-   * than or equal to the given minimum (microAlgos or decimal units of an ASA). */
+   * than or equal to the given minimum (microAlgos or decimal units of an ASA if type: axfer). */
   minAmount?: number
   /** Filter to transactions where the amount being transferred is less than
-   * or equal to the given maximum (microAlgos or decimal units of an ASA). */
+   * or equal to the given maximum (microAlgos or decimal units of an ASA if type: axfer). */
   maxAmount?: number
   /** Filter to app transactions that have the given ARC-0004 method selector for
    * the given method signature as the first app argument. */