Introduce insert menu and adjust select widths #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an insert menu with placeholder items for images and attachments for testing next week. Manually set the width of the selects to ensure that the visual editor toolbar fits on one line.
dnkrj
force-pushed
the
2601-insert-element-menu-component
branch
from
0758248 to
8182857
Compare
ryanb-gds
reviewed
May 17, 2024
| @@ -239,13 +256,14 @@ function redoMenuItem(schema) { | |||
| function items(schema, editorView) { | |||
| return [ | |||
| headingMenuItem(schema), | |||
| select(headingMenuSelectOptions(schema), editorView), | |||
| select(headingMenuSelectOptions(schema), editorView, "headingSelect"), | |||
There was a problem hiding this comment.
Is having camel case class names a bit weird at all?
There was a problem hiding this comment.
You're right, will merge in a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/YZpwh0xp/2601-insert-element-menu-component
Screenshot