Add temporary debug logging for refund notifications on test merchant #5682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbishop1
requested changes
Jan 14, 2025
src/main/java/uk/gov/pay/connector/gateway/worldpay/WorldpayNotificationService.java
Outdated
Show resolved
Hide resolved
This change adds additional logging to inspect the complete notification payload from Worldpay specifically for refund notifications (REFUND_FAILED and SENT_FOR_REFUND statuses) on the test merchant account (GBSRECABOFFGDSGBPTEST). The extra logging will help investigate where Worldpay includes the refund request ID in their notifications, since we discovered that the 'reference' field is being used for: - authorization code (for successful refunds) - failure reason (for failed refunds) The logging is strictly limited to the test merchant to avoid exposing PII in production environments. Further information in JIRA. https://payments-platform.atlassian.net/browse/PP-13416
marcotranchino
force-pushed
the
PP-13416-add-logs-for-refunds
branch
from
10b3f52 to
3f91f21
Compare
alexbishop1
approved these changes
Jan 14, 2025
kbottla
reviewed
Jan 14, 2025
src/main/java/uk/gov/pay/connector/gateway/worldpay/WorldpayNotificationService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds additional logging to inspect the complete notification payload from Worldpay specifically for refund notifications (REFUND_FAILED and SENT_FOR_REFUND statuses) on the test merchant account (GBSRECABOFFGDSGBPTEST).
The extra logging will help investigate where Worldpay includes the refund request ID in their notifications, since we discovered that the 'reference' field is being used for:
The logging is strictly limited to the test merchant to avoid exposing PII in production environments.
Further information in JIRA.
https://payments-platform.atlassian.net/browse/PP-13416