Skip to content

Commit

Permalink
refactor(dashboard_app): make more explicit max_length for smart_join()
Browse files Browse the repository at this point in the history
  • Loading branch information
Elijas committed Dec 28, 2023
1 parent 0877edf commit 0d9ac75
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dev_utils/dashboard_app/python_utils.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
def smart_join(strings, max_length=50):
def smart_join(strings, max_length: int):
result = ""
for i, string in enumerate(strings):
# Add a newline if the string is long or the previous string was long
Expand Down
2 changes: 1 addition & 1 deletion dev_utils/dashboard_app/select_reports.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def __call__(self, value):

to_add = [k for k in addlist if k not in current]
current.extend(to_add)
queries = smart_join(current)
queries = smart_join(current, max_length=50)

st.session_state.select_reports__queries = queries
st_utils.st_unkeep("select_reports__queries")
Expand Down

0 comments on commit 0d9ac75

Please sign in to comment.