-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator rollup #40223
Merged
Merged
Validator rollup #40223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
banaag
commented
Jan 9, 2025
- cl/713373388 Two-way sync for PR ✨ add validation for amp-social-share in amp-story #40094. No-op, or fixes merge conflicts, if any.
- cl/614818595 Fix validation for duplicate attribute names
- cl/610820873 Fix validation for unexpected attribute name starting with =
пт, 10 янв. 2025 г., 02:21 Allan Banaag ***@***.***>:
…
- cl/713373388 Two-way sync for PR #40094
<#40094>. No-op, or fixes
merge conflicts, if any.
- cl/614818595 Fix validation for duplicate attribute names
- cl/610820873 Fix validation for unexpected attribute name starting
with =
------------------------------
You can view, comment on, or merge this pull request online at:
#40223
Commit Summary
- e747ae5
<e747ae5>
cl/610820873 Fix validation for unexpected attribute name starting with =
- 07bc1ed
<07bc1ed>
cl/614818595 Fix validation for duplicate attribute names
- 22d44ce
<22d44ce>
cl/713373388 Two-way sync for PR #40094. No-op, or fixes merge conflicts,
if any.
File Changes
(5 files <https://github.com/ampproject/amphtml/pull/40223/files>)
- *M*
extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.out
<https://github.com/ampproject/amphtml/pull/40223/files#diff-dc438d1cafb313feb1d45cc5a25326f40a010f308e3cf4717057f9840afd268e>
(106)
- *M* validator/testdata/feature_tests/duplicate_attribute.out.cpponly
<https://github.com/ampproject/amphtml/pull/40223/files#diff-af6179e8a41fb76529a1d4b161299972fd0b359e8a80659e9ddefa236ddc5f09>
(12)
- *M* validator/testdata/feature_tests/leaks.html
<https://github.com/ampproject/amphtml/pull/40223/files#diff-45ff4d93c0c2fbff8a7fce93a45a2a437a4e1c2e1ed34cd7c576d1c328db6a95>
(5)
- *M* validator/testdata/feature_tests/leaks.out
<https://github.com/ampproject/amphtml/pull/40223/files#diff-2a3347de7fb58ccbd6e58758891a8133fc5424a4cf2316a2362ec9a4480cc6fc>
(9)
- *M* validator/testdata/feature_tests/leaks.out.cpponly
<https://github.com/ampproject/amphtml/pull/40223/files#diff-834cb6367ba18abdbdff82fb52fa17c492ae528714bd7d361e6cb14815222b0b>
(151)
Patch Links:
- https://github.com/ampproject/amphtml/pull/40223.patch
- https://github.com/ampproject/amphtml/pull/40223.diff
—
Reply to this email directly, view it on GitHub
<#40223>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BASFD27OZLIJNJPBWO73XNT2J3D3DAVCNFSM6AAAAABU43IS3OVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43TQNJZGE3TONQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
erwinmombay
approved these changes
Jan 9, 2025
пт, 10 янв. 2025 г., 02:22 erwin mombay ***@***.***>:
… ***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#40223 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BASFD24B4PUQXAQMTUXKQR32J3D7FAVCNFSM6AAAAABU43IS3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBQG42TIMRUGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.