bugfix(client): Fix the panic due to concurrent writing #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
The bug:
panic: concurrent write to websocket connection
goroutine 66624 [running]:
github.com/gorilla/websocket.(*messageWriter).flushFrame(0xc001ad7ef0, 0x1, {0x0?, 0x0?, 0x0?})
/home/streampanel/go/pkg/mod/github.com/gorilla/websocket@v1.5.3/conn.go:617 +0x4b8
github.com/gorilla/websocket.(*messageWriter).Close(0xc001e12f60?)
/home/streampanel/go/pkg/mod/github.com/gorilla/websocket@v1.5.3/conn.go:731 +0x35
github.com/gorilla/websocket.(*Conn).beginMessage(0xc001e034a0, 0xc001e12f60, 0x8)
/home/streampanel/go/pkg/mod/github.com/gorilla/websocket@v1.5.3/conn.go:480 +0x3a
github.com/gorilla/websocket.(*Conn).NextWriter(0xc001e034a0, 0x8)
/home/streampanel/go/pkg/mod/github.com/gorilla/websocket@v1.5.3/conn.go:520 +0x3f
github.com/gorilla/websocket.(*Conn).WriteMessage(0x37d2cb0?, 0x1e5f71c?, {0xc000945490, 0x5, 0x5})
/home/streampanel/go/pkg/mod/github.com/gorilla/websocket@v1.5.3/conn.go:773 +0x137
github.com/andreykaipov/goobs.(*Client).Disconnect(0xc001c26fc0)
/home/streampanel/go/pkg/mod/github.com/xaionaro-go/goobs@v0.0.0-20241009130652-ffb0e76ad260/client.go:123 +0xe5
The documentation of github.com/gorilla/websocket explicitly forbids concurrent writing and reading.
See section "Concurrency" in:
https://pkg.go.dev/github.com/gorilla/websocket#hdr-Concurrency
xaionaro
force-pushed
the
bugfix/panic_concurrent_writing
branch
from
e75f683 to
7bb4b24
Compare
andreykaipov
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix(client): Fix the panic due to concurrent writing
The bug:
The documentation of github.com/gorilla/websocket explicitly forbids concurrent writing and reading.
See section "Concurrency" in: https://pkg.go.dev/github.com/gorilla/websocket#hdr-Concurrency