Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR with some of my changes.
This adds derive macros for
TryRead
andTryWrite
.Some notes:
Ctx
is set toEndian
, this is the most ergonomic option, but it could be made more flexible with a macro attribute in the future#[byte(read_ctx/write_ctx = ...)]
field attribute that allows specifying custom context per field, the context expression can use values of preceding fields in the structimpl
is a bit awkward to use sometimes becausetry_write
is defined to takeself
by value, which necessitates cloning - this could be worked around by having the derive generate an impl for &Self, but that'll not work when you nest structs, I think the best option would be to re-defineTryWrite
to take&self
instead ofself
Measure
trait I've added in another PRUsage