-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.0.0 final release #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
MrSteve81
reviewed
Mar 20, 2024
MrSteve81
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check notes sent
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
MrSteve81
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This was referenced Mar 21, 2024
Closed
Merged
uk-bolly
added a commit
that referenced
this pull request
May 1, 2024
* #18 corrected Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated due to #19 great catch Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * V2.0.0 final release (#24) * removed warn: false Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * fix typos Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * addressed #21 Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated 1.1.2 logic Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated handler Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Correct 4.1.15 sudo audit syntax (#26) Signed-off-by: Andrew Davison <andrew.davison@worldpay.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> Signed-off-by: Andrew Davison <andrew.davison@worldpay.com> Co-authored-by: Andrew Davison <wp-davisona@users.noreply.github.com>
mfortin
pushed a commit
to mfortin/AMAZON2-CIS
that referenced
this pull request
Jun 7, 2024
* ansible-lockdown#18 corrected Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated due to ansible-lockdown#19 great catch Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * V2.0.0 final release (ansible-lockdown#24) * removed warn: false Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * fix typos Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * addressed ansible-lockdown#21 Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated 1.1.2 logic Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * updated handler Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> * Correct 4.1.15 sudo audit syntax (ansible-lockdown#26) Signed-off-by: Andrew Davison <andrew.davison@worldpay.com> --------- Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> Signed-off-by: Andrew Davison <andrew.davison@worldpay.com> Co-authored-by: Andrew Davison <wp-davisona@users.noreply.github.com> Signed-off-by: fortinm <mathieu.fortin@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Issues addressed
typos fixed
Issue Fixes:
#21 thanks to @chrisdleech-pol
#22 thanks to @mfortin
Enhancements:
typo fixed
How has this been tested?:
Manually