Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0.0 final release #24

Merged
merged 5 commits into from
Mar 20, 2024
Merged

V2.0.0 final release #24

merged 5 commits into from
Mar 20, 2024

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:
Issues addressed
typos fixed

Issue Fixes:
#21 thanks to @chrisdleech-pol
#22 thanks to @mfortin

Enhancements:
typo fixed

How has this been tested?:
Manually

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check notes sent

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@uk-bolly uk-bolly merged commit 7acc728 into devel Mar 20, 2024
3 checks passed
@uk-bolly uk-bolly deleted the March24 branch March 20, 2024 14:46
This was referenced Mar 21, 2024
@uk-bolly uk-bolly mentioned this pull request May 1, 2024
uk-bolly added a commit that referenced this pull request May 1, 2024
* #18 corrected

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated due to #19 great catch

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* V2.0.0 final release (#24)

* removed warn: false

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* fix typos

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* addressed #21

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated 1.1.2 logic

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated handler

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

---------

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* Correct 4.1.15 sudo audit syntax (#26)

Signed-off-by: Andrew Davison <andrew.davison@worldpay.com>

---------

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Andrew Davison <andrew.davison@worldpay.com>
Co-authored-by: Andrew Davison <wp-davisona@users.noreply.github.com>
mfortin pushed a commit to mfortin/AMAZON2-CIS that referenced this pull request Jun 7, 2024
* ansible-lockdown#18 corrected

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated due to ansible-lockdown#19 great catch

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* V2.0.0 final release (ansible-lockdown#24)

* removed warn: false

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* fix typos

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* addressed ansible-lockdown#21

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated 1.1.2 logic

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated handler

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

---------

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* Correct 4.1.15 sudo audit syntax (ansible-lockdown#26)

Signed-off-by: Andrew Davison <andrew.davison@worldpay.com>

---------

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Andrew Davison <andrew.davison@worldpay.com>
Co-authored-by: Andrew Davison <wp-davisona@users.noreply.github.com>
Signed-off-by: fortinm <mathieu.fortin@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants